java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

feat: Added Serialized lob design pattern (Issue #1596)

Open yixingz3 opened this issue 2 years ago • 2 comments

  • Added SLOB design pattern.
  • Serialize a graph into a single large object (LOB) and store it in the database.

This issue has two duplications, #1314 and #1596. At the time I picked the issue, I didn't realize there was a nearly completed PR for #1314. And I was going with a slightly different approach (without XML), hopefully it's still okay.

Also, I understand that this issue (#1596) was assigned to @dctrue2 a few weeks ago. We are working as a team to contribute to different issues (~6) in this repo. And in this case, I will submit the PR for #1596 and another member of my team will submit the PR for the issue that I initially signed up for. We are sorry about the confusion and hope this wouldn't be too much inconvenience for you. I will be actively making changes to this PR and aiming for merging it in (if the approach is okay), so please let me know what you think and what I can do, Thank you!

yixingz3 avatar Nov 20 '21 01:11 yixingz3

Thank you @iluwatar for the feedback! I fixed everything besides changing the topic as it might be more involved and at the moment, I have many things to juggle in hand...Hopefully, other issues have all been fixed and looked good. And if it's possible for this PR to be merged before Friday, it would be really really awesome since we have a term project due on Friday and merging it would be a great success. Thank you again for reviewing the PR!

ghost avatar Dec 07 '21 01:12 ghost

Looks good, but now there are some problems building the pull request. Can you try to merge master into this branch to see if it helps?

Yep, fetched and merged master into my branch. Hopefully, it works this time, Could you try again?

ghost avatar Dec 20 '21 04:12 ghost