30-seconds-of-java icon indicating copy to clipboard operation
30-seconds-of-java copied to clipboard

Add code snippet for Generate random numbers

Open asilenko opened this issue 3 years ago • 6 comments

Added code snippet for Issue #105 :

  • created two methods: -> for random number between x and y -> for throwing dice
  • added tests for both methods,
  • updated Readme.md

asilenko avatar Oct 27 '21 16:10 asilenko

Ready for review.

asilenko avatar Nov 06 '21 15:11 asilenko

You need to fix the failing build

I had some trouble working with checkstyle.xml It seems to be OK by now. In addition I added one new test to check if all numbers from given range were generated.

asilenko avatar Nov 20 '21 07:11 asilenko

Sorry for the delay. Hope this last commit has fixed the problem with the checkstyle. I'm new to gradle. The project still do not build on my device but the reason is build.gradle file. I'm not sure if I should fix it along with this issue. Let me know if it's ok.

asilenko avatar Jan 08 '22 22:01 asilenko

@asilenko I added some more instructions in the PR https://github.com/iluwatar/30-seconds-of-java/pull/119 Maybe you find that helpful.

iluwatar avatar Jan 09 '22 15:01 iluwatar

@asilenko I added some more instructions in the PR #119 Maybe you find that helpful.

Thank you. I fixed the licence, but I don't see any checkstyle warning when I try to build the project. If it still does not work just pass the task to someone else. Sorry for wasting your time.

asilenko avatar Jan 09 '22 17:01 asilenko

Ok, @asilenko I checked your code very fast and in my Idea everything compile successfully... almost. In class GenerateRandomNumbersSnippetTest change line 67. Line is longer than 100 characters. In checkstyle.xml at line 34 the max line length value equals 100. Line 67 has 102.

grzesiekkedzior avatar Jan 09 '22 22:01 grzesiekkedzior

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 31 '22 17:12 stale[bot]

Closed due to inactivity. Thank you for your contributions.

stale[bot] avatar Feb 14 '23 19:02 stale[bot]