30-seconds-of-java
30-seconds-of-java copied to clipboard
Add code snippet for Generate random numbers
Added code snippet for Issue #105 :
- created two methods: -> for random number between x and y -> for throwing dice
- added tests for both methods,
- updated Readme.md
Ready for review.
You need to fix the failing build
I had some trouble working with checkstyle.xml It seems to be OK by now. In addition I added one new test to check if all numbers from given range were generated.
Sorry for the delay. Hope this last commit has fixed the problem with the checkstyle. I'm new to gradle. The project still do not build on my device but the reason is build.gradle file. I'm not sure if I should fix it along with this issue. Let me know if it's ok.
@asilenko I added some more instructions in the PR https://github.com/iluwatar/30-seconds-of-java/pull/119 Maybe you find that helpful.
@asilenko I added some more instructions in the PR #119 Maybe you find that helpful.
Thank you. I fixed the licence, but I don't see any checkstyle warning when I try to build the project. If it still does not work just pass the task to someone else. Sorry for wasting your time.
Ok, @asilenko I checked your code very fast and in my Idea everything compile successfully... almost. In class GenerateRandomNumbersSnippetTest change line 67. Line is longer than 100 characters. In checkstyle.xml at line 34 the max line length value equals 100. Line 67 has 102.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Closed due to inactivity. Thank you for your contributions.