30-seconds-of-java icon indicating copy to clipboard operation
30-seconds-of-java copied to clipboard

(Issue #34) Added Elo Rating snippet and tests

Open dchar opened this issue 3 years ago • 4 comments

Added: EloRatingSnippet.java EloRatingSnippetTest.java

dchar avatar Aug 02 '21 01:08 dchar

Apologies @iluwatar, I am just returning from vacation. Thank you for taking the time to review my PR. Checkstyle corrections are in. Please let me know if anything more is needed.

Thanks, Dylan

dchar avatar Sep 02 '21 23:09 dchar

Apologies @iluwatar, I am just returning from vacation. Thank you for taking the time to review my PR. Checkstyle corrections are in. Please let me know if anything more is needed.

Thanks, Dylan

Hey Dylan, good to have you back. Unfortunately, the build is still failing due to Checkstyle.

iluwatar avatar Sep 07 '21 18:09 iluwatar

This was my mistake -- looks like there was trouble running the Checkstyle locally. I referred to the logs and pushed another update.

If anyone has any recommendation for running this locally (specifically with IntelliJ), I'd be happy to learn more. I see the following errors when trying to load the custom file:

com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:473) at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:201) at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:61) at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:26) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.executeCommand(CheckstyleActionsImpl.java:130) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:60) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:51) at org.infernus.idea.checkstyle.checker.CheckerFactoryWorker.run(CheckerFactoryWorker.java:46) ...

I assume the issues are related to versioning. If there are any more problems with the build, I'll try to turn them around immediately.

Thanks, Dylan

dchar avatar Sep 07 '21 23:09 dchar

Thank you for your time and patience. I've addressed each of the recommendations. README.md updates did not want to push -- the entire file was throwing Java warnings, but opted to commit anyway.

Thanks, Dylan

dchar avatar Sep 10 '21 22:09 dchar

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 04 '22 19:12 stale[bot]

Closed due to inactivity. Thank you for your contributions.

stale[bot] avatar Jan 18 '23 21:01 stale[bot]