Andrey Loskutov

Results 414 comments of Andrey Loskutov

Note, some of the information (like hostname) might require API calls that might hang Eclipse, so we should avoid using them. Other data (like `DISPLAY`) might be only available on...

Fixed via https://github.com/eclipse-platform/eclipse.platform.ui/pull/2347

I've just rebased on head to see current test result.

@raghucssit : could you please update the fix & rebase?

I've first rebased but then I saw that version (and some smaller code) changes needed so I've amended last commit. Here is the diff: https://github.com/eclipse-platform/eclipse.platform.ui/compare/ee5c4b2479915e3b26c3f4b5c552d9dc1d041c88..73abc2ff90c58692f34047a21712f5d299b9ca57

> The service handling looks fine now I just have some remarks as this is adding new API at a very late stage Come on, we are in M2 now....

> Is there a good way to actually test this? Start IDE in debugger on this PR, go to Preferences / Capabilities, switch off PDE ![image](https://github.com/user-attachments/assets/6629d87d-f967-4c23-88d1-02f6d6e31e1f) and check that Window...

> So when adding a new E4 service it should at laest be designed with such use-case in mind Let name it `E3ActivityManagerBridge` or `E3ActivityManagerProxy` or `InternalE3ActivityManagerServiceHelper` to avoid confusion...

> Thanks I'll try that out, so mentioned "category" (==getEnabledActivityIds() would be "general") and "Identifier" (== PDE) ? No. Just check in debugger what you will see in ActivityManagerProxy.isIdentifierEnabled().

> @raghucssit @iloveeclipse I have now created > > * [Consider Activity Filtering when running in E3 compatibility mode #2768](https://github.com/eclipse-platform/eclipse.platform.ui/pull/2768) > > this does not require any new service and...