René Dudfield comments

Results 648 comments of


                                            René Dudfield

Context names - checking they are handled correctly

/remove-lifecycle rotten

Context names - checking they are handled correctly

I think this has been done already in a couple of efforts. Including research into it and some new unit tests were added. So making this closed as completed (rather...

frontend: cluster: hooks: Make useList multi cluster aware

I removed useKubeObjectLists, and now just useKubeObjectList is exported. The multi cluster version is internal. The tests are now passing in CI.

Being able to provide a default service address to prometheus

Good idea. @trashhead I wonder if configuring this through a config map would be acceptable? Then the plugin could search for a config map "headlampPluginPrometheusServiceURL". In the helm chart it...

frontend: EditButton: Use JSON patch to prevent resource version conflicts

This is a really nice fix. I need some time to test it though. So I marked it for the 0.38.0 release. My initial question is what happens if someone...

frontend: EditButton: Use JSON patch to prevent resource version conflicts

I wonder if last-write-wins is the way in these cases? I think it could be a bit dangerous. Currently it doesn't let them apply, so they have to try again....

frontend: EditButton: Use JSON patch to prevent resource version conflicts

@jaehanbyun I spent some time on Friday thinking about this.... I think your proposal would be very very good. (Sorry it took quite some time to get to this)

frontend: EditButton: Use JSON patch to prevent resource version conflicts

@jaehanbyun There's a related PR to this at: - https://github.com/kubernetes-sigs/headlamp/pull/4269 What do you think?

I18n improvements

Thanks @ashu8912 @vyncent-t could you also please review/test?

Remove usage of execSync in scripts

Thanks. I want to hold off on this until after 0.37.0