attractions icon indicating copy to clipboard operation
attractions copied to clipboard

Change markup to be more valid

Open illright opened this issue 3 years ago • 0 comments

We should add a block prop to the button to swap the underlying element for a <div>. Let that prop be incompatible with href.

We should also use <span> elements for Subhead and Label typographic components.

I'm thinking that Chip, Dot components should also become <span> instead of <div>.

Not sure what to do with Popover. Feels like it shouldn't affect the nature of its content. Maybe also a block prop? Feels weird

illright avatar Aug 22 '21 20:08 illright