vscode-vibrancy-continued icon indicating copy to clipboard operation
vscode-vibrancy-continued copied to clipboard

[Bug] Cannot minimize or maximize VSCode on Windows

Open codeAbinash opened this issue 10 months ago • 18 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Cannot minimize or maximize window.

Expected Behavior

Minimizing or maximizing window should work.

Steps To Reproduce

Vibrancy Continued v1.1.29

Environment

- OS: Windows 11
- VSCode: 1.87.2
- Extension: Vibrancy Continued v1.1.29
- Theme: One Dark Pro Darker

Anything else?

Rounded corners are also not available in window.

codeAbinash avatar Apr 02 '24 12:04 codeAbinash

Known issue due to breaking Electron 27 changes as mentioned in the description, currently no workaround besides downgrading VSCode to 1.85.2, will keep this issue open for future updates.

illixion avatar Apr 02 '24 12:04 illixion

Even after downgrading VSCode to 1.85.2 the minimize/max- functionality still doesn't work! image

kanetjuh avatar Apr 14 '24 15:04 kanetjuh

Same error, any solution?

FrankmDev avatar Apr 21 '24 10:04 FrankmDev

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

avaneesh-pandey5 avatar May 05 '24 07:05 avaneesh-pandey5

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

emuel-vassallo avatar May 05 '24 10:05 emuel-vassallo

Same error on v1.89.1 image

minecraftfen avatar May 24 '24 16:05 minecraftfen

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

Life saver! This has worked for me!

dustingleaton avatar May 25 '24 19:05 dustingleaton

The same thing (1.89.1)

MrOxMasTer avatar Jun 04 '24 12:06 MrOxMasTer

Everyone on Windows with VSCode 1.86.0 and newer is currently experiencing this issue, no need to +1 unless you have something to add to the discussion.

As a reminder, Vibrancy needs to be reloaded after downgrading VSCode as mentioned earlier by another user.

illixion avatar Jun 04 '24 13:06 illixion

I am using FancyWM, and it seems like whatever bug is causing this is also causing FancyWM to not work. It cannot resize or move vscode.

mikaib avatar Jun 09 '24 14:06 mikaib

@kacwos

Everyone on Windows with VSCode 1.86.0 and newer is currently experiencing this issue, no need to +1 unless you have something to add to the discussion.

As a reminder, Vibrancy needs to be reloaded after downgrading VSCode as mentioned earlier by another user.

As illixion said, EVERYONE is currently experiencing this issue, so please do NOT comment when you cannot provide any information to help solve the problem.

When you comment, everyone who subscribed this issue will get a notification, if your comment can't help everyone, it will cause unnecessary disturbance.

minecraftfen avatar Jun 18 '24 01:06 minecraftfen

How can I solve this problem so that vibrancy works but does not have this problem?

You need to downgrade to VSCode 1.85.2, which is clearly mentioned in the first reply in this thread and at the very top of Vibrancy’s description.

illixion avatar Jun 18 '24 05:06 illixion

Guys, after I pressed F1 and type "Disable Vibrancy" I uninstalled the extention, and I reinstalled the vs code, it worked

ismail-elmokhfi avatar Jun 26 '24 20:06 ismail-elmokhfi

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

Thanks a bunch brother. Saved my life

Souvik0046 avatar Jul 12 '24 05:07 Souvik0046

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

It Worked very well !!

prabeenragupathi avatar Aug 08 '24 15:08 prabeenragupathi

It's been 7 updates and this issue is still not fixed, if someone knows how minimize and maximize functions works, pls answers to this comment, so we can try to fix it and make a pull request

JackBlaze132 avatar Aug 17 '24 02:08 JackBlaze132

It's been 7 updates and this issue is still not fixed, if someone knows how minimize and maximize functions works, pls answers to this comment, so we can try to fix it and make a pull request

It's indeed annoying. I just swiched to windows for work and being unable to snap VSCode is slowly getting me.

I quickly searched but cannot find anything related to window resizing in Electron 27 changelog But its probably due to the fact that this plugin overrides the default behaviour of moving and resizing. Line 33 : vscode-vibrancy-continued/blob/main/runtime/win10refresh.js :

/**
 * Unfortunately, we have to re-implement moving and resizing.
 * Enabling vibrancy slows down the window's event handling loop to the
 * point building a mouse event backlog. If you just handle these events
 * in the backlog without taking the time difference into consideration,
 * you end up with visible movement lag.
 * We tried pairing 'will-move' with 'move', but Electron actually sends the
 * 'move' events _before_ Windows actually commits to the operation. There's
 * likely some queuing going on that's getting backed up. This is not the case
 * with 'will-resize' and 'resize', which need to use the default behavior
 * for compatibility with soft DPI scaling.
 * The ideal rate of moving and resizing is based on the vertical sync
 * rate: if your display is only fully updating at 120 Hz, we shouldn't
 * be attempting to reset positions or sizes any faster than 120 Hz.
 * If we were doing this in a browser context, we would just use
 * requestAnimationFrame and call it a day. But we're not inside of a
 * browser context here, so we have to resort to clever hacks.
 * This VerticalRefreshRateContext maps a point in screen space to the
 * vertical sync rate of the display(s) actually handing that point.
 * It handles multiple displays with varying vertical sync rates,
 * and changes to the display configuration while this process is running.
 */

Is This workaround still necessarry ? It seems janky at best.

koebelt avatar Sep 10 '24 14:09 koebelt

@koebelt there is at least one person who reported that this fix was necessary for them: https://github.com/illixion/vscode-vibrancy-continued/issues/52

There was also more discussion here about refactoring this fix: https://github.com/illixion/vscode-vibrancy-continued/issues/38

illixion avatar Sep 11 '24 11:09 illixion