tiptap-vuetify icon indicating copy to clipboard operation
tiptap-vuetify copied to clipboard

Issues when trying to write a custom ColorPicker extension

Open leo91000 opened this issue 4 years ago • 3 comments

Hi,

I am trying to implement a color picker for tip tap vuetify in a fork to maybe do a pull request if it works well.

However, when the commands is executed (toggleWrap) it doesn't do anything. Do you have any idea why is that ? I have never used prosemirror so I am a bit confused.

Also, are you opened to a pull request when it is done ?

Thanks

leo91000 avatar May 30 '20 17:05 leo91000

Hi, wow! You have done a lot of work and it is a very good idea to add a color picker!

Also, are you opened to a pull request when it is done ?

Yes, of course, I am glad to accept any PR, especially such cool ones.

Why it does not work, I can’t say for sure. We need to try different options. Can you try this code? I took it from here. You can also see about how they made the extension here.

Let me know if there is a problem in my library, I will try to fix it.

Thanks again for your efforts on the new extension, I will be glad to see it in my library.

iliyaZelenko avatar Jun 01 '20 14:06 iliyaZelenko

Did not try your code but this does not look right:

document.querySelector('body')!.appendChild(instance.$el)

michi88 avatar Jun 22 '20 07:06 michi88

This should be implemented in this package, is this on the list of things to add? Such a great and needed feature. Nice work on this, by the way, looking for something similar to https://github.com/Leecason/element-tiptap

timothymarois avatar Jul 02 '21 16:07 timothymarois