Mike Boutin
Mike Boutin
Finally got a few minutes to finish up the review! Diff below or you can use https://github.com/crystal-growth/uom/compare/aos_particle_unit...iliekturtles:uom:aos_particle_unit. Mostly formatting fixes again. I also updated electron volt per mole to the...
What I would do is force-push your new branch to the existing branch. Assuming your remote is named `origin` and the command line, the following will do this: `git push...
Excellent. Thanks so much for the PR!
https://github.com/iliekturtles/uom/pull/229#issuecomment-1169055412 > Logarithmic units require `pow`/`root` functions which are not available in no-std/no-libm builds. Excluding logarthmic units has proven difficult (in-place filter foiled by macros unable to be used inside...
MSRV bumped to 1.60.0 in #422. I haven't started looking at this issue yet.
MSRV bumped to 1.60.0 in #422. I haven't started looking at this issue yet.
Thanks for the latest update. Some errors in the build. I have a busy weekend coming up but will see if I can track down where they're coming from.
MSRV bumped to 1.60.0 in #422. I haven't started looking at this issue yet.
MSRV bumped to 1.60.0 in #422. I haven't started looking at this issue yet.
Skipping this one for the moment (partial changes at https://github.com/iliekturtles/uom/tree/add_elementary_particle_mass_units). I want to dig deeper and find out why the real CODATA values have precision issues.