Ilia Ross
Ilia Ross
> Yeah, `read_file_contents` would work just as well. Alright, although I think there is a better solution. Have a look at [this patch](https://github.com/webmin/webmin/commit/d5a3eebe85a00a66247178eb2a5a428a040e7102). > I'm not sure what other types...
Jamie, alright. I have changed existing regex to be a bit more catchy. We generally should be fine. However, I am still not 100% sure if we're covering it all....
We could technically test for: ```
> Maybe the only safe option is to always download, and remove the option to show in the browser entirely? Probably not, because there are a lot of use cases...
I know but we don't have many options.
Is JPG totally save though?
> Well we could just not show those files in the browser at all ... just limit to files that are 100% safe or can be safely filtered, like GIF,...
> Are you sure it's safe to use the same function to filter JS from PDF and HTML? Well, even thought it'd be safe most likely, after thinking more over...
Hello Daniel! After checking both version 2 and version 3 of your modules from your GitHub repo, I couldn't find the `edit_volumes.cgi` file in either package. I couldn't reproduce the...
Hello, I like this suggestion! Also, we don't yet support interactive mode with `-f` flag in log viewer, which would as well be a great feature to have