Ian Leitch

Results 161 comments of Ian Leitch

False positive with dictionary key

Yep, that's the same issue. I'm planning to try fix this issue myself, in time for Swift 5.6... but I've hardly any time recently for Periphery.

Periphery doesn't work as expected when `skip_build: true` and `index_store_path` specified

Hey @subdan, sorry for such a late reply on this. Did you manage to get any further? Is the issue that the index store path to the source file is...

Retain protocols that inherits JSExport protocol

Using `--retain-objc-accessible` should correctly retain these protocols, though it might actually be nice to retain JS accessible without having to use `--retain-objc-accessible`. An option like `--retain-js-accessible` might be appropriate.

False positive: class extension declaration: when a typeAlias is used in order to specify the extended class

Thanks for reporting, I will investigate soon.

Inconsistent results between runs (again)

Are any of the results false positives? Or is it just sometimes omitting some correct results? > For example, there's a struct where most of its properties are marked as...

Inconsistent results between runs (again)

Are the results inconsistent also when using --skip-build? Or does skip-build take 1 hour? 😮

Inconsistent results between runs (again)

Ah, is this running in CI?

Inconsistent results between runs (again)

Unfortunately that's a known bug in Swift - https://bugs.swift.org/browse/SR-14162. I plan to get this fixed for Swift 5.6. That still shouldn't cause inconsistent behavior though.

Inconsistent results between runs (again)

2 & 3 are pretty much the same step, and yes that part is concurrent. Step 4 is where things can get a bit complicated. Before we actually walk the...

Inconsistent results between runs (again)

I suspect this most likely isn't a concurrency issue. Step 4 is single threaded, because it takes only a fraction of overall time compared to 1, 2 & 3. It's...