module-alias icon indicating copy to clipboard operation
module-alias copied to clipboard

Published 20 hours ago • verified publisher icon ilearnio

Update index.js

Open danosyrus opened this issue 2 years ago • 3 comments

Updated var keyword into let (Es6) Updated functions into arrow functions (Es6)

danosyrus avatar Mar 12 '22 07:03 danosyrus

Hey @Dano57 ! Thanks for contributing.

I have no taken the time to port the tests to GH Actions (from Travis CI). However we do support all the way back to node v0.10, and I believe there are no let or arrow functions in that version...

I'll keep the PR open until I port the tests, but I will probably close it when the tests turn out to be failing.

Kehrlann avatar Mar 14 '22 20:03 Kehrlann

Okay

danosyrus avatar Mar 16 '22 02:03 danosyrus

@Kehrlann I just spent some time seeing how the tests would run in GitHub Actions. Here is what I have so far, if you want to take a look. Basically tests pass on every Node.js version except 0.10.0 and 5.x. https://github.com/jamesmortensen/module-alias/runs/5573638135?check_suite_focus=true.

I opened a pr here: https://github.com/ilearnio/module-alias/pull/126

jamesmortensen avatar Mar 16 '22 17:03 jamesmortensen