Benoît Viguier

You may want to read this: https://lycheeorg.github.io/docs/contributions.html#how-to-properly-submit-a-pull-request-to-lychee It will help you too. :)

Sorry should have given you this link, it is more explanatory: https://lycheeorg.github.io/docs/contributions.html#illustrated-example :) You cannot directly push to LycheeOrg as you are not part of the organization (yet? :) )....

Maybe I should also add an Illustrated example if someone uses the command line. :)

Also worth having a look: https://www.php.net/manual/en/language.fibers.php

This was the original implementation (v3 and early v4). We decided to move to single thumb image for the following reasons: - **simpler code in the back end** (if you...

Still need to fix the tests obviously.

I went for the quick&dirty solution as I would like to not take too much of your time with heavy code refactoring. I would say though that we now make...

> I really not to test that thoroughly Fortunately, there is an extensive test suite in that regard see UsersTests.php

https://github.com/LycheeOrg/Lychee/pull/1403/commits/6a8e9bba9ac54ba793c88b73542a6fe9f9202f7a : was was needed or the test under with `$userId === null` was useless.

@nagmat84 don't hate me too much. I pretty much nuked all the logic out of Authorization. :'D I strongly suggest to read through: https://github.com/LycheeOrg/Lychee/pull/1403/commits/3f54e8eea32683ff41f6c033d20e9ebb1541021e The changes are pretty much search&replace.