Benoît Viguier

Results 454 comments of Benoît Viguier

> Regarding live photos: it seems they are stored beside the photo. That's why I added the storage disk to the photo model too. Otherwise, there is currently no way...

> In the Album/Delete.php action, album tracks are added to the file deleter ([s3-pipes/app/Actions/Album/Delete.php#L110](https://github.com/LycheeOrg/Lychee/blob/s3-pipes/app/Actions/Album/Delete.php?rgh-link-date=2024-02-07T17%3A12%3A09Z#L110)) after the deleter was run. Can this be removed? Not sure if they are used for...

Also a few nice tips. - if you are not using the git hooks for formatting, you can run `make formatting` to apply the style. - Tests are available at...

> My issue right now is the immense complexity of the application. I am sorry about that. :( > Not sure how you want to implement the album track deletion...

> I hate to say this, but I guess the completion of the feature is up to you. I don't feel confident in getting the whole picture right. I should...

@Kovah can I trouble you to test the latest code? Please have `PHOTO_PIPES=true` in your `.env` In theory the videos should now be uploaded to s3 too. If you can...

Thanks for the feedback! > App\Models\Photo::toArray:28 livewire.update:App\Models\Photo->toArray() I will look into that. > [2024-02-20 15:50:29] dev.ERROR: App\Actions\Photo\Pipes\Duplicate\ReplicateAsPhoto::handle:13 Call to a member function replicate() on null I will look into that...

If you would like to help, I am more than happy to accept pull requests on the `livewire/more-work` branch. The file you will want to modify is the following: https://github.com/LycheeOrg/Lychee/blob/master/resources/views/livewire/pages/landing.blade.php...

> The total number of pictures, including in subalbums, strikes me as much harder to implement efficiently than it would seem, though. We currently don't keep track of the count,...

> today I updated from 4.1 to 4.2.2 and it looks like the counts are gone. Is there a new setting I miss? Most likely a bug. Can you open...