clickhouse_fdw icon indicating copy to clipboard operation
clickhouse_fdw copied to clipboard
verified publisher icon ildus

Add "json" support

Open iosifnicolae2 opened this issue 3 years ago • 7 comments

Fixes #87

iosifnicolae2 avatar Jun 16 '22 13:06 iosifnicolae2

I'm just been walking around It would be cool if you add tests also

Denchick avatar Jun 30 '22 09:06 Denchick

Unfortunately I'm not that used on writing c++ code, so I don't know exactly how add the appropriate tests..

iosifnicolae2 avatar Jul 07 '22 12:07 iosifnicolae2

Well, you don't need to know how to write tests in C++ :) There is a folder tests in the root of the repository, inside there are also two folders: sql and expected. How to run tests you can see in Makefile

Denchick avatar Jul 15 '22 04:07 Denchick

hello guys, i have same issue. when this PR will be merged?

manakao avatar Sep 07 '22 03:09 manakao

@ildus, hi! Could you approve to run tests here?

Denchick avatar Jan 31 '23 07:01 Denchick

@iosifnicolae2 could you add sql tests for it (look for the comment from @Denchick)? That will show that the patch is working. Also please remove .idea files.

ildus avatar Sep 22 '23 07:09 ildus

@ildus sorry, but currently I don't have time to invest into creating a proper PR request, if anyone is interesting into doing this, it would be great.

Thank you!

iosifnicolae2 avatar Sep 22 '23 07:09 iosifnicolae2