Ilhan Polat
Ilhan Polat
> My opinionated approach was on the "rewrite" side: work on providing sane equivalents (hence BSpline, make_splrep), declare the old stuff legacy and don't touch it with a barge pole....
I guess CircleCI Python issue is not going to be resolved soon so should we put this in?
OK fingers crossed then. Thanks Evgeni for the review.
Ah OK, it wasn't working in the PR. I'll take a look. I could not replicate this locally though.
The code breakdown is as follows (using tokei tool) ```bash SLICOT-Reference git:(main) tokei --sort code --exclude="examples/" --exclude="benchmark_data" =============================================================================== Language Files Lines Code Comments Blanks =============================================================================== HTML 587 179197 162832 4...
Nice work! But the annoying part is still the fortran dependence unfortunately. I already wrote bunch of SLICOT routines in C just to try out. I'll push maybe this weekend...
I added some structure and started pushing some routines now to SLICUTLET. It is not compilable as a library yet but I'll add more details this weekend (hopefully).
Yes it seems like a wrapper copy/paste mistake. I'll add this one to the list in #24022
`s*sqrt(0.0)` will still be 0.0 so maybe I'm not at my best at understanding today but I don't see the issue.
You have to rewrite everything for that I'm afraid (or use NumPy scalars everywhere). Other branches also have lots of places that use Python scalars.