Ilhan Polat
Ilhan Polat
May I suggest a less if, else language such as > If alpha is set to zero, A and B are not referenced to avoid unnecessary math. A potential downside...
> Your version changes the meaning slightly, because "A and B are not referenced" would imply a no-touch-guarantee (no reads, no writes to any array element), which is something I...
I also dare to ping (and possibly annoy) @jvendrow and @lucasbotang in case they are interested in improving this solver using Bro & De Jong algorithm. In the current release...
Thank you @mdhaber much appreciated. You are right about the mutation. I thought asarray copies but apparently not, I'll fix.Good catch. The residual is strange indeed I'll check.
> but I realized that the function is mutating A. Now explicit copies are done at the outset on Cython side, regardless of the input to make sure. > Even...
@mdhaber I know you are quite busy with other PRs. Do you think you can have a final look?
Ah great! Then I'll wait for a few days and click in case someone else does not. Thank you @h-vetinari !
As an external verification from #21140, which seems to hit all parts of the inner loop, I think this is correct for cases we tried out. I'll click it in...
Hi @jd-edp. It is going to show up in version 1.15 that will be out in about a month.
After rewriting in C in #22748 , the performance for this particular problem did not improve with the new code. If Octave is converging that fast, then probably they modified...