Ilhan Polat
Ilhan Polat
Yes, not sure if this is going to be used but just dumping all translated parts to PR so I can collate them into one place. This one has some...
Thanks @inkydragon. It's the python extension module part I did not have any idea what the functions are doing. Otherwise the machinery is pretty much there indeed.
Sure this won't make it to 1.15 so better to remove the milestone.
In there are no objections, I'd like to hit the button with this one.
Thanks Albert for the review and all for the comments.
I would suggest a name like tensor_svd or something. It's too close to hankel sv's and also difficult to relate to the abbreviation SVD.
After another coffee, to be perfectly honest, tensor word starts to sound like jargon after a while since NumPy takes pride in calling everything "ndarray', I'm not even sure I...
> Also optional but nice to have, consider adding some typing. We slowly want to add these across the library. Do we actually? This is something I really want to...
For the naming, I think the ship has sailed to do anything about tensor usage so probably `tensor_svd` would be the most recognizable thing following the suite `tensordot`. I don't...
I don't agree. The python community is definitely not going towards the typing direction. There is a huge resistance from the regular users. The IDE argument doesn't make a strong...