CMIN_moment_retrieval icon indicating copy to clipboard operation
CMIN_moment_retrieval copied to clipboard

Bug in data loader?

Open ChenyunWu opened this issue 4 years ago • 3 comments

In CMIN_moment_retrieval/dataloaders/clip_loader.py line 66 if label[1] == video.shape[0] - 1: Shouldn't it be: if label[1] == ori_video_len:? Since you changed the video and its length is now always self.max_num_frames

ChenyunWu avatar Oct 02 '20 03:10 ChenyunWu

I think the logic of this code feels strange!!!

onlyonewater avatar Oct 06 '20 15:10 onlyonewater

In CMIN_moment_retrieval/dataloaders/clip_loader.py line 66 if label[1] == video.shape[0] - 1: Shouldn't it be: if label[1] == ori_video_len:? Since you changed the video and its length is now always self.max_num_frames

Thanks for reminding. We have corrected this in the subsequent use but have not updated this code. Even with a low probability, this may cause an error when length > self.max_num_frames and label[1] == self.max_num_frames - 1.

ikuinen avatar Nov 22 '20 08:11 ikuinen

Dear ChenyunWu:

Could you please tell me how to process the splitted C3D features of Activity Caption dataset? It is weired five parts and I cannot figure out how to restore such files with suffixs of .part-XX.

Starboy-at-earth avatar Mar 13 '21 12:03 Starboy-at-earth