dlang-requests icon indicating copy to clipboard operation
dlang-requests copied to clipboard

Add windows ssl functionality in addition to openssl

Open andre2007 opened this issue 7 years ago • 5 comments

Please add the option to use windows ssl functionality in addition to openssl. There are two major benefits:

  • No need to copy / package openssl libraries
  • In case there are implementation issues with the windows ssl library, these issue will be solved automatically by Microsoft with the next update. In case of openssl, the corrected library has to be shipped to all customers using the application

andre2007 avatar Aug 08 '17 21:08 andre2007

The documentation also needs to describe how that issue is resolved. It's not really acceptable that the application cannot query https resources, but there is no description of the error or how to resolve it. Simply copying OpenSSL dlls doesn't seem to work.

dub\packages\requests-0.7.2\requests\source\requests\ssl_adapter.d:_staticCtor38:66 warning: failed to load libssl - first access over https will fail

GeirGrusom avatar Mar 05 '18 10:03 GeirGrusom

Hello, @GeirGrusom

I need a bit more info - did you installed openssl? Simply copying might not work.

ikod avatar Mar 05 '18 13:03 ikod

I got it to work; I renamed ssleay32.dll to libssl32.dll. But it would still be nice with a Windows implementation that didn't require OpenSSL :)

GeirGrusom avatar Mar 05 '18 14:03 GeirGrusom

nice to hear, as for Windows implementation of SSL - I have almost absolute zero experience with programming for Windows, so... (I'm waiting for any brave contributor :)

ikod avatar Mar 05 '18 14:03 ikod

Thank you for this library anyway, you've done a good job!

To not come off as a whiny github issue commentor I could take a stab at this, but between billable hours and family time I'm stretched fairly thin so no promises :)

GeirGrusom avatar Mar 05 '18 14:03 GeirGrusom