PurpleCloud icon indicating copy to clipboard operation
PurpleCloud copied to clipboard

Jinja2 instead of template_file.

Open mosesrenegade opened this issue 2 years ago • 2 comments

While working on a different project, I came across a great idea for building Terraform Templates. This came from the Amazon Account Factory Terraform modules, which use jinja-cli to convert Jinja templates into Terraform files. I decided to refactor your phishing_app template. Please note the following:

  • templates/phishing_app. Jinja would be where the Jinja based terraform module will live within the generator
  • phishing_app.py is much smaller, with less code required to make it work. You will need to have a requirements.txt that installed Jinja2 itself.

mosesrenegade avatar Dec 03 '22 15:12 mosesrenegade

Hello,

Please make the necessary changes to the file "requirements.txt" and submit that also as a pull request before contributing to this branch of [PurpleCloud]. For code review. Please note that this is the master branch and must be revised by other open-source software users before merging.

dorp007 avatar Mar 01 '23 00:03 dorp007

Hello,

Please make the necessary changes to the file "requirements.txt" and submit that also as a pull request before contributing to this branch of [PurpleCloud]. For code review. Please note that this is the master branch and must be revised by other open-source software users before merging.

This is a great idea for enhancement. But we need to make this change across all 8 of the generators, coordinate the changes, and update the documentation. Waiting to see if someone can make the changes or I'll prioritize this myself at some point in the future.

iknowjason avatar Mar 17 '23 14:03 iknowjason