Versioning Arduino

[jacobrosenthal]

Presumably under arduinomock/include/arduinomock wed have a versioned folder, arduino1.0 1.5 1.6.

Frankly those might need to be complete new repos each and you can pick which to bring in with submodules or something.

That being said I dont actually need the versioning, I just need to know what we're version we're going to go forward with if I PR some files so we dont start mixing them up.

[ikeyasu]

Copied Jacob's messge for the discussion https://gitter.im/ikeyasu/arduino-mock?at=54d90616119229eb4eac2931

Jacob said..

I was able to pull in Stream and Printable all untouched. Just once crazy thing in Print. I cant seem to override the virtual

virtual size_t write(const uint8_t *buffer, size_t size);

I have code that cross compiles and runs on device, but that same code mocked just cant override that function..

c++ -isystem ./googletest/include -isystem ./gmock/include -I./arduino-mock/include/arduino-mock/ -g -Wall -Wextra -pthread -Wno-missing-field-initializers -Wno-missing-braces -Wno-unused-command-line-argument -lpthread NullStream.o NullStream_unittest.o gmock_main.a arduino_mock_all.a -o
 NullStream_unittest Undefined symbols for architecture x86_64: "Print::write(unsigned char const*, unsigned long)", referenced from: vtable for Stream in NullStream_unittest.o "typeinfo for Print", referenced from: typeinfo for Stream in NullStream.o typeinfo for Stream in NullStream_unittest.o "vtable for Print", referenced from: Print::Print() in NullStream_unittest.o NOTE: a missing vtable usually means the first non-inline virtual member function has no definition. ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make: *** [NullStream_unittest] Error 1

[ikeyasu]

Thank you for pointing it out. I think we should focus on stable version. As you know, Arduino released 1.6.0 2 days ago. We should shift to 1.6.0 if there is differences.

http://arduino.cc/en/Main/ReleaseNotes

How do you think?

[jacobrosenthal]

Sounds good. It would be good to begin versioning folder path though a) to be explicit and b) for when someone wants to do the work to support an older version or c) when they release 1.7 etc.

On Wed, Feb 11, 2015 at 12:55 AM, IKEUCHI Yasuki [email protected] wrote:

Thank you for pointing it out. I think we should focus on stable version. As you know, Arduino released 1.6.0 2 days ago. We should shift to 1.6.0 if there is differences.

http://arduino.cc/en/Main/ReleaseNotes

How do you think?

— Reply to this email directly or view it on GitHub https://github.com/ikeyasu/arduino-mock/issues/21#issuecomment-73844530.

[jacobrosenthal]

I think the question is do you want to version by checkout out a new branch/fork/submodule or by changing the makefile?

[ikeyasu]

For the question, I think Makefile is better. Anyway, we need a discussion about what is an ideal way for the mock.