Kevin Brian Bader

Results 214 comments of Kevin Brian Bader

I'm looking into a fix for https://github.com/Expensify/App/issues/51388 not passing.

@shubham1206agra I looked into the blank screen issue and this is what I found, related to this block: https://github.com/Expensify/App/blob/082e14b9bc1259c329c7cd186ee8f21c0397f6fb/src/pages/Debug/Report/DebugReportPage.tsx#L148 which is calling: ```ts function navigateToConciergeChatAndDeleteReport(reportID: string, shouldPopToTop = false, shouldDeleteChildReports...

@shubham1206agra Ready for review once again! Addressed the mentioned [issue](https://github.com/Expensify/App/pull/53408#issuecomment-2531458338) in https://github.com/Expensify/App/pull/53408#issuecomment-2537798958.

@shubham1206agra It works, but only for popping the first screen aka Debug - Report after we confirm `Delete`, the other 2 report related screens remaining in the stack and causing...

@shubham1206agra Indeed, `popToTop` should pop all but for some reason it's not working: ```ts /** * Pop to the first route in the stack, dismissing all other screens. */ popToTop():...

@shubham1206agra I reverted that previous commit and fixed `Navigation.goBack`'s `shouldPopToTop` logic instead, as described in https://github.com/Expensify/App/pull/53408#issuecomment-2538021480. Ready for review once again, if you find any other issues please let me...

@shubham1206agra Any input on the latest changes, are we good to move forward with the PR ?

Looking into it, will attempt a similar fix to the previous one - will tag you once its ready.

Still working on this, will get back with some results soon.

@shubham1206agra The PR is ready for review once again! ## What happens in https://github.com/Expensify/App/pull/53408#issuecomment-2543188347 is that `withReportOrNotFound` (which wraps ReportDetailsPage) returns `null` (blank page) [here](https://github.com/Expensify/App/pull/53408/files#diff-f296915d3c6aaf0c12a16e29e6ef6855a0ec3d0e234914b8baa143e37e0ea579R109-R111) when pusher event comes from...