Ikemen-GO icon indicating copy to clipboard operation
Ikemen-GO copied to clipboard

Calculation of showspeed/hidespeed broken for P2 side

Open Ksylatarsh opened this issue 1 year ago • 2 comments

Describe the bug

For some reason, combo counter and lifebar action's show/hide speed is broken if you change the localcoord of the fight.def (in my tests it stopped sliding after 360x240) this must be a coordinate issue.

To Reproduce

test_case.zip

Latest nightly build (05/08/23) with the fight.def edited to showcase this error, just get into a versus match and do a small 2 hit combo to P1.

Expected behavior

It should slide in-correctly and smoothly depending on the show/hide speed just like P1's.

Screenshots / Video

https://user-images.githubusercontent.com/126763763/236938882-4441d66f-3fee-4707-b9da-126fa11204e4.mp4

Expected behavior vs. wrong behavior

Engine Version (or source code date)

Nightly - 05/08

Operating system

Windows

Extra context or search terms

combo counter, lifebar action, hidespeed, showspeed, lifebars, fight.def

Ksylatarsh avatar May 08 '23 21:05 Ksylatarsh

I think this is just because you changed the localcoord without adjusting the position of the text accordingly.

But you may have a point because the final position after sliding looks alright but the sliding itself doesn't. Probably some parts of the code are foolproof but others aren't.

potsmugen avatar May 24 '23 16:05 potsmugen

I think this is just because you changed the localcoord without adjusting the position of the text accordingly.

Not really, I did change the text position accordingly on other screenpacks as well and nothing seems to happen at all either on them.

Ksylatarsh avatar Jun 07 '23 18:06 Ksylatarsh