ikelos
ikelos
Well, I'll take a look at the PR once it comes out to see how invasive it is, but targetting a fix for something that comes out in two weeks,...
(It also proves we need to be careful about whether we add class overrides or optional class overrides when we add extensions).
Ok, I'm glad we chose the right type for the structure, and yes, it's very disappointing they decided to make that change now. As I said, I take a look...
So it sounds like the fix would be to make a `module_sect_attrs` class override, that determines whether it contains the needed classes, and then either processes attrs to yields each...
It looks like it's because we're explicitly checking the type with `type(thing) == ...`. The should be `isinstance` which can take a tuple/list
So instead of `and type(symbol_info) not in valid_address_types` we probably want `and not isinstance(symbol_info, valid_address_types)`
(Same for valid_name_types just above it)
The may not work if the types passed in are strings rather than the actual types, but I wouldn't expect the error message to list calsses if they were just...
Yeah, we stash everything we receive directly into a cache file. I guess we could either mark is as temp until we know it all downloaded (although that doesn't cope...
Ok, so the fix probably belongs in [this](https://github.com/volatilityfoundation/volatility3/blob/0b04a138adc208aa980af83e17cdf42dbdd72102/volatility3/framework/symbols/windows/pdbutil.py#L261) region of the code. I haven't fully figured out where but there seems to be very little exception handling around there. I'll...