rqbit
rqbit copied to clipboard
Add Dockerfile and Compose
Hello 👋🏿
This PR is to add a Dockerfile to use with rqbit. I'm currently using it in a Raspberry pi 4 and in laptop.
Things that need to improve is:
- Change the DTH and the session path for persistence.
- Change the Docker registry repository used for this image.
- Build an image for each OS architecture.
Hi @marcosrosse, thanks for your contribution.
There are a few things that make me uncomfortable merging this.
- I can't reference a docker image "docker.io/marcosrossem/rqbit:latest", as it's not under my control.
- I don't have docker and thus can't support this going forward.
However I would be fine merging it if the PR would make Github Actions build and publish the docker image automatically to docker.io. For you to test this, I imagine you'd need to fork the repo, set up a Github Action that publishes to docker.io
That's it for the first review round. Alternatively, you can create a repo like rqbit-docker or smth like that and publish the docker support there.
@ikatson @marcosrosse the default with github actions is to use ghcr.io (github packages), which would allow control to stay with the repo.
Added docker builds to main CI. Not yet multiarch, but will do that too later