rqbit icon indicating copy to clipboard operation
rqbit copied to clipboard

Add Dockerfile and Compose

Open marcosrosse opened this issue 1 year ago • 2 comments

Hello 👋🏿

This PR is to add a Dockerfile to use with rqbit. I'm currently using it in a Raspberry pi 4 and in laptop.

Things that need to improve is:

  • Change the DTH and the session path for persistence.
  • Change the Docker registry repository used for this image.
  • Build an image for each OS architecture.

marcosrosse avatar Feb 18 '24 15:02 marcosrosse

Hi @marcosrosse, thanks for your contribution.

There are a few things that make me uncomfortable merging this.

  1. I can't reference a docker image "docker.io/marcosrossem/rqbit:latest", as it's not under my control.
  2. I don't have docker and thus can't support this going forward.

However I would be fine merging it if the PR would make Github Actions build and publish the docker image automatically to docker.io. For you to test this, I imagine you'd need to fork the repo, set up a Github Action that publishes to docker.io

That's it for the first review round. Alternatively, you can create a repo like rqbit-docker or smth like that and publish the docker support there.

ikatson avatar Feb 18 '24 19:02 ikatson

@ikatson @marcosrosse the default with github actions is to use ghcr.io (github packages), which would allow control to stay with the repo.

infowolfe avatar Jun 22 '24 15:06 infowolfe

Added docker builds to main CI. Not yet multiarch, but will do that too later

ikatson avatar Aug 26 '24 13:08 ikatson