vscode-phpcs icon indicating copy to clipboard operation
vscode-phpcs copied to clipboard
verified publisher icon ikappas

[Discussion] [Live Share] Restricting language services to local files

Open lostintangent opened this issue 7 years ago • 1 comments

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for PHP, this PR simply updates the current DocumentSelector to be limited to local files. This way, when someone has the PHPCS extension installed, and joins a Live Share session (where files use the vsls: scheme), their diagnostics will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

lostintangent avatar Apr 17 '18 05:04 lostintangent

@ikappas Any thoughts on this proposal? It's fully backwards compatible with the current extension, and so shouldn't be a risky change.

lostintangent avatar Apr 18 '18 05:04 lostintangent