HAP-python icon indicating copy to clipboard operation
HAP-python copied to clipboard

More Sphinx Work

Open jslay88 opened this issue 7 years ago • 12 comments

Putting this issue here to track progress on the Sphinx Documentation.

Todo:

  • We will need to go through more of the project and switch over to sphinx docstrings. I only hit Accessory, Bridge, and AccessoryDriver.
  • Ubuntu LTS Installation Pre-Requisites.
  • More things, please comment for what you see missing.
  • intro/examples.rst
  • intro/tutorial.rst
  • intro/overview.rst

jslay88 avatar Feb 19 '18 06:02 jslay88

You mean the git pushes?

ikalchev avatar Feb 19 '18 06:02 ikalchev

No, this basically, is for the work that needs to be done still to finish out the documentation so that others can see our needs for documentation, and can also contribute.

The tag will be good for organizational/filtering purposes for people looking specifically for documentation work.

jslay88 avatar Feb 19 '18 06:02 jslay88

Like so?

ikalchev avatar Feb 19 '18 06:02 ikalchev

Yeah, also, since you are more familiar with the scope of the project, can you please let me, and others here, know what else besides the 3 classes I already hit, that need to be documented with priority?

jslay88 avatar Feb 19 '18 06:02 jslay88

Also, it should be ready to be able to hook into readthedocs.io

https://docs.readthedocs.io/en/latest/getting_started.html#sign-up-and-connect-an-external-account

jslay88 avatar Feb 19 '18 06:02 jslay88

  1. pyhap/characteristic.py
  2. pyhap/service.py
  3. pyhap/util.py - good to have but not at all that important right now

Yes, I was thinking of readthedocs and will probably do it in the following days.

ikalchev avatar Feb 19 '18 06:02 ikalchev

Keep in mind that the sphinx docstrings are different.

:param x:

instead of

@param x:

jslay88 avatar Feb 19 '18 08:02 jslay88

Doesn't look like the PYTHONPATH is getting set on rtd. API is not building out the autoclass. Investigating.

jslay88 avatar Feb 21 '18 07:02 jslay88

I barely had the time to do the Travis and rtd integrations, hopefully I full find more time soon. Thanks for keeping an eye on that.

ikalchev avatar Feb 21 '18 07:02 ikalchev

No problem. Got it figured out. Will post more info in a few minutes once I have everything nailed down.

jslay88 avatar Feb 21 '18 07:02 jslay88

Ok, there may be a few settings to change on RTD.

Under the project panel, Admin -> Advanced Settings

  • We need to have Install your project inside a virtualenv using setup.py install checked.
  • Python interpreter needs to be set to CPython3.x

I will submit a PR for the code changes needed.

jslay88 avatar Feb 21 '18 07:02 jslay88

Also, these have been documented from the last doc merge.

  • Characteristic
  • CharLoader
  • Service
  • ServiceLoader
  • Util

jslay88 avatar Feb 21 '18 07:02 jslay88