Results 90 comments of Ian Campbell

Thanks. This seems like an improvement even if we can't go as far as confirming ACPI is ok -- it definitely wasn't ok before. Would you mind raising a PR...

Ack to your first two bullets. Not sure I quite follow the third. By "I don't `Resource` needs a copyable method" did you mean "I don't think `Resource` needs a...

I take it your use of "environment" assume #78 has happened and will try to interpret with that in mind and use that term throughout. So I think you are...

> That proposal looks good. There was at least 3 in https://github.com/containerd/continuity/issues/95#issuecomment-334187464 ;-) Do you have a favourite? > One other thing to consider is the behavior: do this "sync"...

> it would be nice to avoid the creation of the manifest, as hashing the whole filesystem is expensive when your syncing to an empty directory tree. I'm unclear if...

I finally started looking into implementing this week (before I got distracted again)... It looks like `continuity.ApplyManifest` already covers most of the use case here, in my copious free time...

My use case for this was to achieve the same thing which https://github.com/containerd/cri-containerd/pull/535 did much more simply. Given that I no longer have a pressing need for this functionality. Probably...

In the context of reason `(1)` in the description quoted above `EINTR` is just what you get if some signal was delivered to the process, it doesn't kill the process...

Hi @hawkw I see that #1608 was merged a while back, but I'm unclear how to use it to turn `time.*` into a fixed unit. Looking at it again now...