guider icon indicating copy to clipboard operation
guider copied to clipboard

Fix error indication for a successful program analysis

Open elfring opened this issue 4 years ago • 7 comments
trafficstars

I tried the current analysis tool out once more.

[Markus_Elfring@fedora lokal]$ guider/guider.py btrace 'find /home/Markus_Elfring/Downloads -name A5-test1.odt' -c getdents64
… ver_3.9.8_210928 on python_3.9
…
0.130752 +++ exited find(8158) with 0 +++

[ERROR] terminated find(8158)

I wonder about the red information in the last line.

elfring avatar Sep 28 '21 19:09 elfring

It's just about information for user :) in multiple task tracing cases, It helps user can recognize one of them is terminated.

iipeace avatar Sep 29 '21 06:09 iipeace

in multiple task tracing cases,

I traced only one program for my test example.

It helps user can recognize one of them is terminated.

  • How do the displays “…with 0…” and “[ERROR] …” fit together?
  • I find a single result message sufficient here.

elfring avatar Sep 29 '21 06:09 elfring

How do the displays “…with 0…” and “[ERROR] …” fit together?

"... with 0" is for trace mode, [ERROR] is for all mode including trace, profile, ...

they has different purpose for each other. was it uncomfortable?

iipeace avatar Sep 29 '21 07:09 iipeace

I do not expect an error (or info/debug) message at the end after I got the impression that a program analysis test run succeeded.

elfring avatar Sep 29 '21 08:09 elfring

what do you think about changing [ERROR] to [WARN] or [INFO]?

iipeace avatar Sep 29 '21 11:09 iipeace

An alternative category might make more sense for other messages. At which source code places would such an adjustment be applied?

elfring avatar Sep 29 '21 12:09 elfring

You can check at 91,564 line.

                    # print status #
                    SysMgr.printErr(
                        'terminated %s(%s)' % (self.comm, self.pid))

I will change it to ERROR to WARN so that the message will not shown without verbose option.

iipeace avatar Sep 29 '21 13:09 iipeace