iina icon indicating copy to clipboard operation
iina copied to clipboard

Chapters indicator is not visible when video is dark in dark mode

Open rainlycoris opened this issue 1 year ago • 6 comments

System and IINA version:

  • macOS

macos sonoma 14.6.1

  • IINA

iina nightly 10428989095

Expected behavior:

Shows section splits, like the Float (I'm not sure it's called that) and Top styles. 截屏2024-08-17 22 47 19 截屏2024-08-17 22 48 08 The chapter style of the "bottom" style is not displayed in unplayed sections. 截屏2024-08-17 22 49 19

Actual behavior:

Crash report:

mpv log:

Steps to reproduce:

  • [ ] MPV does not have this problem.

How often does this happen?

always

rainlycoris avatar Aug 17 '24 14:08 rainlycoris

In principle this shouldn't happen since the top progress bar and the bottom progress bar use the same exact code and UI elements to setup. When I try to reproduce this issue, I notice that if the video is black (or dark) and your theme is dark as well, the chapter indicators are indeed not visible. Try to forward to another time where the video is not dark or change a video, you can see the tick marks again. So this is a visibility issue rather than a bug.

uiryuu avatar Aug 18 '24 01:08 uiryuu

I'm terribly sorry that I totally missed it. But the "top" and "bottom" are different colors in dark mode. I play the video full screen, so they're all in the black side of the video.

rainlycoris avatar Aug 18 '24 03:08 rainlycoris

This issue with chapter tick marks being hard to see was also reported in issue #3860.

I also find the tick marks with the light theme hard to see. Really hard to see in the dark theme.

low-batt avatar Aug 19 '24 22:08 low-batt

In principle this shouldn't happen since the top progress bar and the bottom progress bar use the same exact code and UI elements to setup.

There is a major difference between them. Each of the 3 OSCs uses an NSVisualEffectView, but each has a different "material":

  • titleBarView uses Title Bar, which is mostly opaque
  • controlBarFloating uses Popover, which seems to be slightly less opaque but still more opaque than not
  • controlBarBottom uses Header View which seems much less opaque than the other two and tends to look darker against a dark background when in dark mode

There is another issue I've noticed which hasn't been mentioned, which is that the tick marks do not scale with the screen resolution. So a 1pt tick mark might be clearly visible on a 40-inch display at 1280x720 resolution, it will be very hard to see on a 13-inch display at 2056x1329 resolution.

svobs avatar Aug 20 '24 08:08 svobs

How do I add chapters, tried to add.CUE file, but when opened, the time is not accurate, such as marked is 30 seconds, the actual display is 20 seconds

uulll avatar Oct 30 '24 05:10 uulll

For the CUE file resulting in incorrect times, please enter a new issue describing the problem. Include a CUE file that exhibits the problem.

low-batt avatar Oct 31 '24 02:10 low-batt

This was fixed in IINA 1.4.0.

low-batt avatar Sep 25 '25 19:09 low-batt