iina
iina copied to clipboard
iina
Fixes to Subtitle Chooser layout
- [x] I have read CONTRIBUTING.md
- [x] This implements/fixes issue #4057.
Description:
- Allow expansion tooltips (as suggested in this comment)
- Set a preferred width of 480 to that it doesn't collapse to size of
osdLabel. Uses a priority of 499 so that it will still shrink if there is not enough space. - Fixes vertical text alignment for each table item's left & right labels
- Fix layout warning
I'm pretty sure @lhc70000 is currently preparing changes in this area as well. The online subtitle providers are being transitioned from the built-in implementations to plug-ins. I believe that involves enhancing the user interface as well.
I'm pretty sure @lhc70000 is currently preparing changes in this area as well. The online subtitle providers are being transitioned from the built-in implementations to plug-ins. I believe that involves enhancing the user interface as well.
Ah, that is good to know. I got carried away and already had more extensive changes prepared. I will hold off on those.
Will have to see what @lhc70000 thinks, but I'm thinking these changes can go into the bug fix release with the improvements @lhc70000 is working on going into the feature release.
This change possibly calls into question my decision, namely this comment:
As the spacing is rather tight I rounded the fps up.
When I was working on that issue I was expecting we would not be altering the OSD for the bug fix release. If we proceed with this change, should we switch the fps to be a floating point number with two fractional digits?
If we proceed with this change, should we switch the fps to be a floating point number with two fractional digits?
I haven't paid much attention to subtitles stuff until now. I'm not sure how helpful or accurate the "fps" field is. But seems like the 2 decimals should be important given its use by traditional standards like 23.98, 29.98, etc.
I guess I'll try posting a new PR with all the fixes I made (which includes that) and see what people think.
I will keep an eye out for the new PR.
The fps field is helpful because if the fps of the video used when authoring the subtitles does not match the fps of the video you are trying to obtain subtitles for then the time codes within the subtitles may not precisely match the video which can cause the subtitles to drift out of synchronization with the video. The accuracy of the subtitle fps I believe depends upon the author correctly reporting that value, so it could be suspect.
