iina icon indicating copy to clipboard operation
iina copied to clipboard

Published 20 hours ago • verified publisher icon iina

lost localization of many strings

Open woshiniming007 opened this issue 1 year ago • 3 comments

  • macOS 12.6
  • IINA 1.3.2

After upgraded to 1.3.2, some localization lost, such as the following panel: 截屏2023-07-09 22 02 08

And there are some other strings in English but I'm not sure if it is new in this version.

woshiniming007 avatar Jul 09 '23 14:07 woshiniming007

Looks like I broke this while I was refactoring QuickSettingsViewController. While I was banging my head against the Video Settings tab, I deleted and recreated some of the text fields, which changed their IDs. I didn't realize at the time that those were needed for localization. Will post a PR which will fix this by changing back to the old IDs.

svobs avatar Jul 10 '23 00:07 svobs

In the PR, I regenerated the file iina/en.lproj/QuickSettingViewController.strings and saw that entries for some minor text are currently missing from develop, such as the s in the time sliders. See the PR for more. But the most glaring omission was for +12 dB: SCR-20230709-owme

svobs avatar Jul 10 '23 00:07 svobs

Also out of scope for this bug, looks like the Traditional Chinese translation for "Gamma" is listed simply as "Gamma": SCR-20230709-teup

svobs avatar Jul 10 '23 05:07 svobs