getmein-web icon indicating copy to clipboard operation
getmein-web copied to clipboard

Add Instruction to take a look at Code of Conduct and Contribution Guidelines

Open aashutoshrathi opened this issue 5 years ago • 20 comments

Add Instruction to take a look at Code of Conduct and Contribution Guidelines on getmein web page, email sent to new member and README too.

aashutoshrathi avatar Oct 04 '18 17:10 aashutoshrathi

screenshot 1

Is this Fine @aashutoshrathi

Ananthavijay avatar Oct 07 '18 15:10 Ananthavijay

@iiitv/project-maintainers if this issue is still open i would like to work on it.

nlok5923 avatar Sep 21 '20 02:09 nlok5923

@nlok5923 GFI

anujpuri72 avatar Sep 21 '20 19:09 anujpuri72

@aashutoshrathi sir please can you help me . I am getting an error while committing changes. Screenshot (1346)

I tried resolving it via some google search but didn't get out of it.

nlok5923 avatar Sep 22 '20 07:09 nlok5923

Try replacing ./node_modules/eslint/bin/eslint.js with eslint in your package.json, don't commit it for now.

aashutoshrathi avatar Sep 22 '20 07:09 aashutoshrathi

@aashutoshrathi thanks sir it worked out . but sir when to commit those changes then.

nlok5923 avatar Sep 22 '20 08:09 nlok5923

@iiitv/project-maintainers We need to make separate issue to make changes in package.json, right?

aashutoshrathi avatar Sep 22 '20 08:09 aashutoshrathi

@aashutoshrathi sir if you want i can work on it.

nlok5923 avatar Sep 22 '20 08:09 nlok5923

@aashutoshrathi sir I tried to implement the feature and keeping the height 100vh in this manner. Screenshot (1350) is it fine sir.

nlok5923 avatar Sep 23 '20 02:09 nlok5923

@nlok5923 also check if your implementation is responsive or not

theyashshahs avatar Sep 23 '20 09:09 theyashshahs

@yashshah2820 sir i checked the above implementation breaks in some mobile sized view. so i changed it a bit. Screenshot (1352)

nlok5923 avatar Sep 23 '20 09:09 nlok5923

please provide a testing link for this 🙂

theyashshahs avatar Sep 23 '20 09:09 theyashshahs

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

Portal to get an invite to IIITV Github organization

nlok5923 avatar Sep 23 '20 09:09 nlok5923

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

**Welcome to IIITV**Portal to get an invite to IIITV Github organization

have you created a PR for these changes?

Portal to get an invite to IIITV Github organization

theyashshahs avatar Sep 23 '20 09:09 theyashshahs

@yashshah2820 no sir for commiting this changes first the issue #124 should get resolved as this issue not allowing me to commit anything.

nlok5923 avatar Sep 23 '20 09:09 nlok5923

can we do this : @iiitv/project-maintainers sir is it possible that i make pr for resolving this issue by replacing ./node_modules/eslint/bin/eslint.js with eslint in package.json and later on we can resolve #124 .

nlok5923 avatar Sep 23 '20 11:09 nlok5923

Hey, read more about git add (Surprise, its not only git add .) command and how you can skip committing and staging files. I think we can get this PR done without touching package.json.

aashutoshrathi avatar Sep 24 '20 05:09 aashutoshrathi

@aashutoshrathi ohh so sorry sir i really forgotten about the same thank you sir

nlok5923 avatar Sep 24 '20 05:09 nlok5923

@iiitv/project-maintainers, I would like to work on the issue.

Ayush-Khandelwal28 avatar Oct 02 '22 06:10 Ayush-Khandelwal28

@iiitv/react-maintainers @Im-Madhur-Gupta

AkhileshManda avatar Oct 02 '22 07:10 AkhileshManda