getmein-web icon indicating copy to clipboard operation
getmein-web copied to clipboard

Published 20 hours ago • verified publisher icon iiitv

Add a code linter

Open aashutoshrathi opened this issue 5 years ago • 11 comments

Add coala or similar linter for JS files. Anyone from @iiitv/batch-of-2021, please take this issue.

aashutoshrathi avatar Sep 20 '18 08:09 aashutoshrathi

@aashutoshrathi can you assign me this issue or I can open a PR?

rahulrana95 avatar Sep 30 '18 15:09 rahulrana95

@rahulrana95 Join our organization using http://getmein.glitch.me Thanks

aashutoshrathi avatar Sep 30 '18 18:09 aashutoshrathi

@aashutoshrathi I have joined the organization. Can you assign the issue to me?

rahulrana95 avatar Oct 01 '18 04:10 rahulrana95

Assigned @rahulrana95

aashutoshrathi avatar Oct 01 '18 06:10 aashutoshrathi

@aashutoshrathi I am not able to push to a new feature branch. Please give me permissions.

rahulrana95 avatar Oct 01 '18 16:10 rahulrana95

Fork and send a PR @rahulrana95

aashutoshrathi avatar Oct 01 '18 16:10 aashutoshrathi

Just curious why coala than eslint?

neolivz avatar Oct 03 '18 03:10 neolivz

We have had good relations with @coala and also have few of our members as active contributors there, plus its easy to integrate, I think.

aashutoshrathi avatar Oct 03 '18 03:10 aashutoshrathi

@aashutoshrathi I have tried coala linter for js but I am not able to find proper documentation to setup it properly. Eslint is widely used as linter for js codebases

rahulrana95 avatar Oct 03 '18 05:10 rahulrana95

A sample commit for you: https://github.com/iiitv/algos/commit/297da0f966d3f1a8bbb4e3e4f5e2d7b7c22dfb9a#diff-e7d7d93b4c8d0df9c9bf21a7d47c83b5 Feel free to read it. 😄

aashutoshrathi avatar Oct 03 '18 05:10 aashutoshrathi

@aashutoshrathi then we can merge the coala one PR i have make. Its working. I just need to add more bears to it else its working as of now.

rahulrana95 avatar Oct 03 '18 06:10 rahulrana95