getmein-web icon indicating copy to clipboard operation
getmein-web copied to clipboard

Fix Lint in windows

Open AmanRaj1608 opened this issue 3 years ago • 3 comments

Expected Behavior

On windows npm run lint gives an error. So we can't commit and push as we husky will give the error again.

Possible Solution

One solution is to add another command for windows in package.json file like "lint-win": "eslint ./public/*.js *.js --fix" and use or in pre-commit so that any one of them will run.

Your Environment

  • Version used: Windows 10

Would you like to work on this issue?

No

AmanRaj1608 avatar Sep 22 '20 15:09 AmanRaj1608

In ref to #54

@iiitv/project-maintainers any better solution?

AmanRaj1608 avatar Sep 22 '20 15:09 AmanRaj1608

@iiitv/project-maintainers can I work on it. because sir I has to make pr for #54 but i can't make it before this issue gets resolved.

nlok5923 avatar Sep 22 '20 18:09 nlok5923

I think this issue is with ./ syntax and also when there is conflicting eslints in env like global and local ones. We might have to come up with better solution

aashutoshrathi avatar Sep 23 '20 02:09 aashutoshrathi