ChefLib icon indicating copy to clipboard operation
ChefLib copied to clipboard

EXPTREE (JULY 17) [CPP]

Open NishantTanwar opened this issue 7 years ago • 15 comments

Fixes #194

  • [x] Pull Request Title is of form EXPTREE (JULY 17) [CPP].
  • [ ] This problem already had an entry in this repository.
    • [ ] This solution is better than the one already in this repository.
  • [x] This solution is prepared by me and not copied from anywhere else on the web.
  • [x] I have added a copyright comment in my solution.
  • [x] I have updated README.md file (in appropriate order).
  • [x] I have read and followed Code Samples.
  • [x] I understand that pull request will be closed if I failed to update it even once in a week.

NishantTanwar avatar Oct 03 '17 10:10 NishantTanwar

Hi! Thanks for contributing to this repository. Make sure you have checked points in PR correctly.

aashutoshrathi avatar Oct 03 '17 10:10 aashutoshrathi

@Monal5031 pls check PR #197 let me know if there is still some error

NishantTanwar avatar Oct 03 '17 11:10 NishantTanwar

@aashutoshrathi @Monal5031 pls justify what is the exact error in my PR

NishantTanwar avatar Oct 03 '17 11:10 NishantTanwar

@NishantTanwar The problem is that you have use space indentations while in this repo we follow tabspaces for c and cpp files. Use tab indentation to pass all the tests. Also don't get frightened over such long messages they are auto-generated issues raised gitmate bot.

Monal5031 avatar Oct 03 '17 21:10 Monal5031

@NishantTanwar Please make changes.

aashutoshrathi avatar Oct 05 '17 18:10 aashutoshrathi

Yeah. I am updating it.

NishantTanwar avatar Oct 05 '17 18:10 NishantTanwar

Please review @Monal5031 I have updated.

NishantTanwar avatar Oct 05 '17 19:10 NishantTanwar

Remove all unwanted files, make your indentation to tabs and add a new line to the end of the file, as soon as Travis Checks become successful, we will merge it.

aashutoshrathi avatar Oct 05 '17 19:10 aashutoshrathi

But I guess I have given proper indentation to tabs and also removed the unwanted files

NishantTanwar avatar Oct 05 '17 19:10 NishantTanwar

No, your PR edits 6 files, while it should edit only 3 (including .gitignote). And you file has space indentation, instead of Tabs (size 4). Make necessary changes.

aashutoshrathi avatar Oct 05 '17 19:10 aashutoshrathi

ping @NishantTanwar Its been 5 days since this PR was last updated, please update it before time.

Monal5031 avatar Oct 10 '17 22:10 Monal5031

@Monal5031 I am not able to get those identation errors hence was not able to update it. I have reviewed my code many times and it seems that I have given tab indentation and not space identation

NishantTanwar avatar Oct 10 '17 22:10 NishantTanwar

@NishantTanwar If you want some help in indenting the code properly you can use coala locally, the command to run it locally on algos directory as

coala --apply-patches -n

but first you need to install coala using

pip3 install coala-bears

This will tab indent the code itself.

Monal5031 avatar Oct 10 '17 22:10 Monal5031

@Monal5031 I added a new line at the end but still didn't work.

NishantTanwar avatar Oct 10 '17 22:10 NishantTanwar

@NishantTanwar Did you try indenting the code using coala, because the space indentation error still persists.

Monal5031 avatar Oct 10 '17 22:10 Monal5031