ChefLib
ChefLib copied to clipboard
EXPTREE (JULY 17) [CPP]
Fixes #194
- [x] Pull Request Title is of form
EXPTREE (JULY 17) [CPP]
. - [ ] This problem already had an entry in this repository.
- [ ] This solution is better than the one already in this repository.
- [x] This solution is prepared by me and not copied from anywhere else on the web.
- [x] I have added a copyright comment in my solution.
- [x] I have updated README.md file (in appropriate order).
- [x] I have read and followed Code Samples.
- [x] I understand that pull request will be closed if I failed to update it even once in a week.
Hi! Thanks for contributing to this repository. Make sure you have checked points in PR correctly.
@Monal5031 pls check PR #197 let me know if there is still some error
@aashutoshrathi @Monal5031 pls justify what is the exact error in my PR
@NishantTanwar The problem is that you have use space indentations while in this repo we follow tabspaces for c and cpp files. Use tab indentation to pass all the tests. Also don't get frightened over such long messages they are auto-generated issues raised gitmate bot.
@NishantTanwar Please make changes.
Yeah. I am updating it.
Please review @Monal5031 I have updated.
Remove all unwanted files, make your indentation to tabs and add a new line to the end of the file, as soon as Travis Checks become successful, we will merge it.
But I guess I have given proper indentation to tabs and also removed the unwanted files
No, your PR edits 6 files, while it should edit only 3 (including .gitignote). And you file has space indentation, instead of Tabs (size 4). Make necessary changes.
ping @NishantTanwar Its been 5 days since this PR was last updated, please update it before time.
@Monal5031 I am not able to get those identation errors hence was not able to update it. I have reviewed my code many times and it seems that I have given tab indentation and not space identation
@NishantTanwar If you want some help in indenting the code properly you can use coala
locally, the command to run it locally on algos
directory as
coala --apply-patches -n
but first you need to install coala using
pip3 install coala-bears
This will tab indent the code itself.
@Monal5031 I added a new line at the end but still didn't work.
@NishantTanwar Did you try indenting the code using coala, because the space indentation error still persists.