Ilya Leoshkevich

Results 39 comments of Ilya Leoshkevich

* Removed unused `endptr` variable in `init_globals()`.

I didn't know about the empty struct restriction, thanks! I guess even if it were allowed, the compiler would still have to implicitly make it at least 1 byte in...

Hi, I think there are no huge compatibility problems for DFLTCC in this PR. I currently have a draft commit that adapts the code and survives the regtest: https://github.com/iii-i/zlib-ng/releases/tag/single-malloc-dfltcc-20240430.

Will do. Unfortunately I found some issues which I don't fully understand yet; but now I have at least a couple bite-sized commits that make sense on their own, which...

`ZCOPY_DEFLATE_STATE` is not an optimization - DFLTCC needs to maintain state of its own, it is allocated alongside deflate/inflate state, and needs to be copied on `deflateCopy()` / `inflateCopy()`. In...

P.S. I wonder in which order this and #1718 should go in? I'd prefer to land #1718 first, since it's more local and as far as I'm concerned is ready.

eBPF CI has a similar setup as zlib-ng (https://github.com/libbpf/ci), and they migrated to aptman/qus:d7.1 (https://github.com/libbpf/ci/blob/5618ba5cc00e40916ecddccbd5f885b29b83b68e/ansible/roles/qemu-user-static/tasks/main.yml, https://github.com/libbpf/ci/blob/5618ba5cc00e40916ecddccbd5f885b29b83b68e/ansible/roles/qemu-user-static/defaults/main.yml). I suggest to give it a try - it should be a drop-in replacement...

Hi, thanks for handling the update - the PR looks good to me. One nit: as far as I can see it doesn't use gaplib directly, so perhaps instead of...

My bad, I tested the MSan build of #1717 without gtest. Would it be reasonable to adjust the test as follows? ``` --- a/test/test_dict.cc +++ b/test/test_dict.cc @@ -50,6 +50,8 @@...

Re: casting to `uintptr_t`, I had a case recently where it did not help for GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114404. Similar issue: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93105. So I would avoid going in this direction.