corona-tracker icon indicating copy to clipboard operation
corona-tracker copied to clipboard

Add option to save data to json file

Open pmpampanio opened this issue 5 years ago • 6 comments

pmpampanio avatar Jun 11 '20 00:06 pmpampanio

I have already opened a pull request concerning issue #5

pmpampanio avatar Jun 11 '20 01:06 pmpampanio

This seems to be irrelevant to the current PR.

  • https://github.com/iidx/corona-tracker/pull/6/commits/631c0c3266cf55d0ea18312a329f4dca9b3bcf34

iidx avatar Jun 11 '20 01:06 iidx

I can, of course, open a new PR if you'd like that concnerns only the related issue (#5) and close this one.

pmpampanio avatar Jun 11 '20 01:06 pmpampanio

  • good feature. however, rather than saving all_statistic and country_statistic at the same time, I think it is better to save them separately.
  • For issues with intellij's configuration file, please request a separate PR (https://github.com/iidx/corona-tracker/pull/6/commits/fc5a456db1a4bbd00f6cb4de675af1851c328504)

iidx avatar Jun 11 '20 02:06 iidx

rather than saving all_statistic and country_statistic at the same time, I think it is better to save them separately.

Could you please further explain your suggestion? Do you mean to have them saved in different json files?

Ethelom avatar Jun 11 '20 02:06 Ethelom

rather than saving all_statistic and country_statistic at the same time, I think it is better to save them separately.

Could you please further explain your suggestion? Do you mean to have them saved in different json files?

I mean it would be much better to have the filename flexible.

stypr avatar Jun 11 '20 03:06 stypr