Ihor Sviziev

Results 212 comments of Ihor Sviziev

I think it's a good idea to ignore XML files, or just add an exception for long class names and leave it enabled for all other lines

I believe it could be done as separate ruleset, not Magento2, so it will not affect all people

@lenaorobei could you defined which severity should be set for this rule? As for me - should be 6, similar to https://github.com/magento/magento-coding-standard/blob/199057a8ca960e0bb191ec8fd7a409fbd91c8a51/Magento2/ruleset.xml#L457-L460 @konarshankar07 I think it's good idea to re-use...

@konarshankar07 do you have any updates? Do you have some working version?

@sivaschenko, This PR adds an ability to automatically fix the failure using `phpcbf` command

Hi @diazwatson, > You can use `Magento\Framework\Filesystem\Io\File` which has a wrapper for that function. > > Example: > https://magento.stackexchange.com/questions/192978/the-use-of-function-pathinfo-is-discouraged-magento-2/284317#284317 Looks really good! Thank you! However it adds alternative only for...

@sivaschenko, could you take a look? We have an example where this issue reproducing on a PR - https://github.com/magento/magento2/pull/35101#issuecomment-1146916983

I guess the changes are the following: https://github.com/magento/magento-coding-standard/pull/405 @Sental, could you confirm that issue is solved now?

Hi @arushibansal013 @fredden, Could you please explain why shouldn't we allow using the `@author` tag in the coding standards? As for me - it might be relevant only to Magento...

I believe all the mentioned tags must not exist in the Magento core, but it should be allowed for the custom extensions. Am I right, @Vinai @sivaschenko ? What I...