penguinV Fix memory leak issue caught by dynamic analysis

Here is a build in Travis-CI where we start having memory leak caught by dynamic analyzer. The issue was introduced by this commit.

After initial investigation we find out that there is a problem in valgrind version change between commits. Here are logs before this changes: one and two, and here are logs after the change: one and two. You could notice that before change the version of valgrind was 1:3.10.1-1ubuntu3~14.5 while after change is 1:3.11.0-1ubuntu4.2.

Jun 07 '19 05:06 ihhub

Hi @yannlabou have you seen such problem previously? Looks like virtual machines on Travis-CI download wrong version of valgrind.

Jun 07 '19 06:06 ihhub

To prove that this issue was not introduced by the change we ran unit tests without any tests here.

Jun 07 '19 06:06 ihhub

Hi @yannlabou have you seen such problem previously? Looks like virtual machines on Travis-CI download wrong version of valgrind.

I don't think that Travis-CI downloaded the wrong package version. valgrind (1:3.10.1-1ubuntu3~14.5) is the one available in Ubuntu Trusty 14.04 and valgring (1:3.11.0-1ubuntu4.2) is the package available in Ubuntu Xenial 16.04. According to the Travis doc, the default linux distribution should be Trusty. In the build log you referenced, we are building on Xenial although we are not explicitly setting the linux distro in our .travis.yml. Maybe Travis changed the default Ubuntu distro?

Jun 09 '19 07:06 yannlabou

I think they changed it.

Jun 09 '19 07:06 ihhub

I think they changed it.

Looks like: https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment

Jun 09 '19 07:06 yannlabou

We're going to try to run this job on GitHub Actions and hopefully we'll fix the problem.

May 18 '20 04:05 ihhub