ihhub
Support 8-directions of attack for wide creatures
Solves #3411
Adds mouse cursor for top/bottom attacks:
Adds attacks originating from "tail" direction:
Hi @usidedown what worries me here is that two concepts are mixed up here: the concept of "vertical attack" in the battle UI (which is OK) and the concept of the "vertical direction of the neighboring cell", which doesn't really exist, because, if you take a look at the battlefield, there is in fact no neighboring cells with a strictly vertical direction. For instance, the Battle::Board::GetIndexDirection() will not be able to return anything sane for such a direction. We IMHO need to separate these concepts somehow, rather than create some kind of "fake" cell directions that nothing corresponds to.
Also I suppose it is impossible to use the swipe mechanics (intended for relatively small touchscreen devices) with these additional directions, right?
Hi @usidedown what worries me here is that two concepts are mixed up here: the concept of "vertical attack" in the battle UI (which is OK) and the concept of the "vertical direction of the neighboring cell", which doesn't really exist, because, if you take a look at the battlefield, there is in fact no neighboring cells with a strictly vertical direction. For instance, the
Battle::Board::GetIndexDirection()will not be able to return anything sane for such a direction. We IMHO need to separate these concepts somehow, rather than create some kind of "fake" cell directions that nothing corresponds to.
Yes you're right, attack directions and cell directions are mixed all around. I'll take a look.
Also I suppose it is impossible to use the swipe mechanics (intended for relatively small touchscreen devices) with these additional directions, right?
Right again! You can attack in 6 directions using swipe. Top and bottom require a little bit more finesse. I'll see what I can do.
@oleg-derevenetz I introduced CellDirection and AttackDirection types. They are similar but CellDirection includes only the 6 directions whereas AttackDirections allows for Top and Bottom attacks. Let me know what you think.
Swipe controls currently have trouble with Top/Bottom because they are hex based. Fixing this would require a fundamental change in the way swipe works. I think it should be done in a separate PR.
@oleg-derevenetz Thank you so much for your fixes!
OK. It may not be possible to do this in a convenient way at all, because the hexes are relatively large and the space to indicate the top/bottom attack is relatively small.
I'm still thinking about it but instead of using source and destination Hexes we can use pixel coordinates. A source + dest points give a vector. It can then be compared to the 8 directions. This way I think it's possible to create 8 equal directions. It's all very preliminary though.
A source + dest points give a vector. It can then be compared to the 8 directions. This way I think it's possible to create 8 equal directions.
There are difficulties with this - the hexes are at least visible on the screen, but these directions are somewhat imaginary, and they are smaller then the hexes (because there are 6 hexes but 8 directions). I'm not sure if this will be convenient.
Hi @usidedown I just made a few more changes, mainly related to improving the clarity of the code by using more "descriptive" names and comments, and by streamlining the logic a bit in a few places. Could you please take a look when you have time?
Hi @usidedown I just made a few more changes, mainly related to improving the clarity of the code by using more "descriptive" names and comments, and by streamlining the logic a bit in a few places. Could you please take a look when you have time?
@oleg-derevenetz Thank you so much for your improvements! Looks good to me.
Hi @Districh-ru. Thank you for taking the time to test this!
I'm afraid I didn't understand the problem, the behavior I see in the video isn't changed from the master branch. The only difference is the cursor which is now pointing upwards instead of top-left.
You can see that with the (new) tail attack the behavior is also as expected:
https://github.com/user-attachments/assets/446ad37d-a904-458d-98c5-4aa653bb3f90
And also a wishlist for the future (not this PR :) ): It'll be good if we can choose the direction of the 2-cell up/down attack: to attack the upper(lower) cell and left or right cell.
I noticed these 2 extra directions, but AFAIK the original game does not allow them.
@usidedown, in the master branch the Phoenix flies to the cell (form left to right), then turns around (changes direction from right to left) and performs diagonal attack from left to right. In this PR Phoenix does not turn around before attacking so by the animation he performs diagonal attack from left to right (burns the bushes) while the damage is applied to the Archers that are not under the fire of Phoenix (by the shown animation).
@Districh-ru Perhaps I am missing something? This is the behavior I get with 1.1.8 release:
https://github.com/user-attachments/assets/95d16807-0216-4425-b558-04552eb5da10
The animation shows that the Phoenix attacks from bottom-left to top-right (the arrow) and the damage is applied to the Archers that are in the top-left direction from the Phoenix and are not under the drawn fire. ~The rotation of wide creature before such attack is missing now. :(~
I'll check the code later..
@usidedown, you are right, we have this issue in the master build including v.1.1.8 release. I did more tests of the master build and this PR and the behavior for two-cells attack is almost the same. My bad. Previously I did not pay so much attention to this animation.
This issue is outside of the scope of this PR and it can be fixed later.
Hi @usidedown , could you please resolve merge conflicts for this pull request?
I am moving this pull request to the next release as we made code freeze for any features for the upcoming release.
Hi @ihhub, could you take a look at this PR when you have the time? Is there more work to be done here?
@usidedown and @oleg-derevenetz a user reported a bug that 2 hex creatures can't attack in the down left direction if a creature is standing to their left. The user says it's version 1.1.9 but I suppose it's a snapshot build from after this PR got merged because you can see a sword pointing straight downwards (?).
https://youtu.be/ZBNs2IPo1zc?si=4Kp0lspH9ZMZYVus
No save is provided but I can request one if needed.
Edit: They've confirmed that this is a snapshot build.
a user reported a bug that 2 hex creatures can't attack in the down left direction if a creature is standing to their left. The user says it's version 1.1.9 but I suppose it's a snapshot build from after this PR got merged because you can see a sword pointing straight downwards (?).
https://youtu.be/ZBNs2IPo1zc?si=4Kp0lspH9ZMZYVus
No save is provided but I can request one if needed.
Edit: They've confirmed that this is a snapshot build.
Yeah, there would be an assertion failure in debug build. In regular build, the attack just won't work :)