fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

endian_h2: fall back to POSIX standard endian.h

Open alarixnia opened this issue 1 year ago • 1 comments

Fixes build on NetBSD.

alarixnia avatar Aug 27 '24 17:08 alarixnia

Hi @alarixnia

fall back to POSIX standard endian.h

endian.h has become part of POSIX just this year, when the Issue 8 was published in June 2024. Please see the CHANGE HISTORY section on the OpenGroup website. Before that, it was not part of the POSIX, and many (otherwise more or less POSIX-compliant) systems do not have it, and will not have it for some time. I'm not sure if it should already be used as a "universal fallback" (although, in principle, why not). Doesn't NetBSD have its own macro symbol, like FreeBSD or OpenBSD? Anyway, please fix the copyright header as suggested by our code style check workflow.

oleg-derevenetz avatar Aug 27 '24 18:08 oleg-derevenetz

Closing this PR in favor of #9098 since the author didn't address given comments.

ihhub avatar Sep 18 '24 14:09 ihhub