fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

[Scenario Editor] Hero's default troop graphics should be displayed with the possible range for the number of creatures

Open LeHerosInconnu opened this issue 1 year ago • 5 comments

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, the hero's default troop graphics should be displayed with the possible range for the number of creatures, e.g. "8-12", "0-4", in each default troop slot.

In fheroes2:

Select standard scenarios 005

Save file

Not needed.

Additional info

No response

LeHerosInconnu avatar Jul 06 '24 15:07 LeHerosInconnu

@LeHerosInconnu. I consider this a request for improvement rather than a bug. Iirc the original editor didn't supply such information either.

zenseii avatar Jul 07 '24 20:07 zenseii

@zenseii,

@LeHerosInconnu. I consider this a request for improvement rather than a bug. Iirc the original editor didn't supply such information either.

I'd thought of putting it as an "improvement", but as I'd put "bug" for the hero's default secondary skills display issue, I wanted to stay consistent. :) And I feel it's more of a bug than an improvement in the way it's presented in the fheroes2's scenario editor.

In the original game's scenario editor, the user takes the step of interacting with the interface to access the possibility of changing the hero's default troops.

In fheroes2's scenario editor, even if the user doesn't wish to modify the hero's troops, the interface that allows him to do so is displayed directly. How can he know what's going to happen? The user may be confused as there are no default troops displayed. "Will the hero have no troops in the scenario, if I don't add creatures in this screen?" "Which creatures will be present in the hero's army?" "How many?"

Even the number of the hero's experience points should be displayed in this screen. I'll open an issue for this later (https://github.com/ihhub/fheroes2/issues/9007).

LeHerosInconnu avatar Jul 08 '24 16:07 LeHerosInconnu

I find having a title for each single slot rather ugly, redundant and clutterd.

Shouldn't just large single description title over each category suffice? Would look cleaner. Something similar to this. deffproto

Mr-Bajs avatar Jul 08 '24 18:07 Mr-Bajs

Hello @Mr-Bajs and @zenseii,

I find having a title for each single slot rather ugly, redundant and clutterd.

Personally, I wouldn't mind simply deleting all the "Default value", "Default troop" and "Default skill" texts in this screen. :)

LeHerosInconnu avatar Jul 28 '24 12:07 LeHerosInconnu

Yes. Just an dark shade would suffice. Same as castle and towns when using default values.

Mr-Bajs avatar Jul 28 '24 15:07 Mr-Bajs