fheroes2
fheroes2 copied to clipboard
ihhub
Update the Vietnamese Translation R.2
Hi, @Nad-SK. Could you please restrict the amount of translated lines to 400 ?
Hi, @Nad-SK. Could you please restrict the amount of translated lines to 400 ? Hi, @zenseii. Now, I'm in edit mode, deleting and adding lines, editing the words in the line also causes the line to be deleted and added. Deleting an entire line still saves the number of deleted lines. Now, to reach the limit of 400 lines, I can only delete all the lines that need to be retranslated, and then translate them in the next PR.
Hi, @zenseii. Now, I'm in edit mode, deleting and adding lines, editing the words in the line also causes the line to be deleted and added. Deleting an entire line still saves the number of deleted lines. Now, to reach the limit of 400 lines, I can only delete all the lines that need to be retranslated, and then translate them in the next PR.
@Nad-SK. This is because you're not "reversing" your changes, your actually making changes by removing the #fuzzy tag and removing the previous placeholder translation. If you want to reduce the amount of changes then you need to readd those translations.
I suggest to look at this page to see what changes your PR contains to better understand what to do: https://github.com/ihhub/fheroes2/pull/8427/files
Hi, @Nad-SK. I will fix the format issues with this PR. After I've done that I suggest that you look over my commits so that you can follow the same procedure if you encounter this problem again.
@Nad-SK, I've now done the tedious work of cutting down your changes to the ones that are relevant.
Please remember this for the next time:
Don't unfuzzy a string and remove the text unless you intend to translate it. Your PR was full of changes which were equal to 0 changes. Like this:
There is 0 reason to at the same time unfuzzy and to remove the text. Either you remove the fuzzy tag because the translation is fine and you have compared it to the new English text, OR you change the Vietnamese text and remove the fuzzy tag. If you are not going to do either one of those then just leave it, because this will show up as at least two changes in your PR.
As you can see, now that I reverted unnecessary un-fuzzying, your total changes went down to 134 from 584.
Also, for your next PR make a new branch and make sure that you have set your local clone's repository settings to "contribute to the upstream". Also, always create a new branch when you make a new PR. Don't make PRs from your master aka
Nad-SK:master:
Hi @Nad-SK , please address given comments by @zenseii .
It's fixed. I've been so busy these past few months.
Hi @Nad-SK , your changes are breaking the compilation. Please take a look at logs which indicate the problem.
Hi, @Nad-SK. Could you please solve the merge conflicts? Is this OK?
The build checks report an error so something went wrong. Please double check the changes you did in your merge commit https://github.com/ihhub/fheroes2/pull/8427/commits/f0a6bc444f43ce20f24b779d59f29903ff3a5fa3
Hi, @Nad-SK. There are 181 lines of changes too many in this PR. Please reduce them so that the PR can be reviewed.