fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Adventure map, there is a slowdown before the window opens in some places

Open LeHerosInconnu opened this issue 1 year ago • 8 comments

Preliminary checks

Platform

Windows

Describe the bug

Windows 7 SP1 - 64 bits

In fheroes2, there is a slowdown before the window opens in some places. In fheroes2:

https://github.com/ihhub/fheroes2/assets/43583994/f470e296-575d-45f8-bf0e-98b9c3e25e32

https://github.com/ihhub/fheroes2/assets/43583994/48229de4-e41e-4e60-becb-c90c0c33f0c6

Save file

Here are the save files: Before shrine 01.zip

Additional info

Windows 7 SP1 - 64 bits

LeHerosInconnu avatar Feb 08 '24 11:02 LeHerosInconnu

Although I can't reproduce this problem on any of my devices, it seems to be due to the fact that for some reason the start of MP3/OGG/FLAC music effect playback on this PC is so slow that it causes a noticeable delay. What happens if you switch the music from External to MIDI in the game settings?

oleg-derevenetz avatar Feb 08 '24 12:02 oleg-derevenetz

Hello @oleg-derevenetz,

Although I can't reproduce this problem on any of my devices, it seems to be due to the fact that for some reason the start of MP3/OGG/FLAC music effect playback on this PC is so slow that it causes a noticeable delay. What happens if you switch the music from External to MIDI in the game settings?

The "Music Type" setting is set to "MIDI" with the default fheroes2 soundfonts, and there are no MP3/OGG/FLAC files present when the problem described was detected.

LeHerosInconnu avatar Feb 08 '24 12:02 LeHerosInconnu

Hello @oleg-derevenetz,

Although I can't reproduce this problem on any of my devices, it seems to be due to the fact that for some reason the start of MP3/OGG/FLAC music effect playback on this PC is so slow that it causes a noticeable delay. What happens if you switch the music from External to MIDI in the game settings?

The "Music Type" setting is set to "MIDI" with the default fheroes2 soundfonts, and there are no MP3/OGG/FLAC files present when the problem described was detected.

Hi @LeHerosInconnu. How about setting the volume to zero? I believe that should skip playing any sounds so that we can verify if that is the issue.

zenseii avatar Feb 08 '24 12:02 zenseii

How about setting the volume to zero? I believe that should skip playing any sounds so that we can verify if that is the issue.

IIRC WAV sound effects are played independently of audio effects volume settings (if volume is set to 0, they just play with volume 0). WAV playback itself is very cheap in comparison with MP3, not to mention MIDI.

oleg-derevenetz avatar Feb 08 '24 12:02 oleg-derevenetz

Hello @zenseii,

Hello @oleg-derevenetz,

Although I can't reproduce this problem on any of my devices, it seems to be due to the fact that for some reason the start of MP3/OGG/FLAC music effect playback on this PC is so slow that it causes a noticeable delay. What happens if you switch the music from External to MIDI in the game settings?

The "Music Type" setting is set to "MIDI" with the default fheroes2 soundfonts, and there are no MP3/OGG/FLAC files present when the problem described was detected.

Hi @LeHerosInconnu. How about setting the volume to zero? I believe that should skip playing any sounds so that we can verify if that is the issue.

I've turned all the settings to "off" and the problem can still be observed.

In fheroes2:

All audio off 01

LeHerosInconnu avatar Feb 08 '24 12:02 LeHerosInconnu

Probably WAV sound effects playback on this Windows 7 PC is now started with a noticeable delay for some reason, which is bad, because WAV playback is very cheap, it doesn't need soundfonts or any complex decoding, like compressed audio formats (MP3 etc). Probably #8375 is observed due to the same reason - WAV sounds of horse steps are started with delay and still not finished when animation is already finished. Don't know why, probably it's some SDL-related issue or maybe even OS-related. I can't reproduce this so far, but I don't have Windows 7.

oleg-derevenetz avatar Feb 08 '24 12:02 oleg-derevenetz

Marking this as an audio-related issue but it's just a guess because I cannot reproduce this on my devices.

oleg-derevenetz avatar Feb 08 '24 14:02 oleg-derevenetz

Hello @Branikolog,

Hi, @LeHerosInconnu Are you using MIDI? I believe this issue is valid only for MIDI sound, while for external music I cannot reproduce this problem.

Yes, MIDI is used when the problem is detected. I did a test with .ogg files in the MUSIC folder and "Music Type" set to "External" and the problem is no longer present. There must have been a change in MIDI management at some point.

Originally posted by @LeHerosInconnu in #8375 (comment)

LeHerosInconnu avatar Feb 10 '24 17:02 LeHerosInconnu