feature: Add aspect ratio info to resolution selection dialog

[Osmodium]

resolves #6586

[oleg-derevenetz]

Hi @Osmodium please remove extra spaces at the end of the line and reorder the includes as suggested by the code style check workflow.

[Osmodium]

I kind of wanted to add the ratios as two new fields on ResolutionInfo but since it needs to be computed based on width and height it would require for the constructor to calculate it, or where it is instantiated to calculate it. Don't know if it would even be a concern since the only time we spend resources calculating it, is when the dialog is shown.

[oleg-derevenetz]

If this ratio is only needed in one place for illustration purpose only, then there is no need to store it in the ResolutionInfo. It is better to calculate it in-place.

[Osmodium]

@ihhub, so I just posted images of potential layouts in the issue to find out which direction to go. I mostly like this one but not showing the x1 (only showing scale when above 1):

[Osmodium]

@ihhub I might even like this layout better

[ihhub]

Hi @Osmodium , since most of readers in the world read text from left to right we have to put the most important information at the left and less important on the right. Ratio factor is less important information I believe. What do you think?

[Osmodium]

Hi @Osmodium , since most of readers in the world read text from left to right we have to put the most important information at the left and less important on the right. Ratio factor is less important information I believe. What do you think?

Hi @ihhub I certainly see your point. I can get behind this format too 😄

[ihhub]

Hi @Osmodium , think about the design from a perspective of a new player. The player will see something like x2 and x3 on the left corner and immediately rises a question "What is this?" While putting it just besides the resolution intuitively is being understandable as a scale factor.

[Osmodium]

Hi @Osmodium , think about the design from a perspective of a new player. The player will see something like x2 and x3 on the left corner and immediately rises a question "What is this?" While putting it just besides the resolution intuitively is being understandable as a scale factor.

Hi @ihhub. This was why I had placed it on the right since it would make more sense it being a scale factor, however I'm not sure all players, new or otherwise will get what a (x2) means intuitively. I tried having it in parenthesies (image is for demonstration purposes) But I feel like this looks too cramped. A thing we could try it to have a header for each column that indicates the information in that column? EDIT: Hmm adding a column might prove a bit more difficult since the dialog is one big sprite :)

[Osmodium]

In the middle:

Here a version where it is at 1/3 instead of in the middle to give room?

[Osmodium]

@ihhub Just for fun, I threw together a dialog with headers :)

[Branikolog]

Hi, @Osmodium , @ihhub !

I personally prefer next alignment more:

Here a version where it is at 1/3 instead of in the middle to give room?

I'd probably shift aspect ratio closer to the central area:

How do you think?

[zenseii]

Personally, I think resolution should always be the leftmost column. It is also more intuitive when the scale factor is attached to it, but you raise a good point about it feeling too crammed if we have resolution in the middle and the ratio to the right.

Honestly I think the best one is the one with the resolution all the way to the left and the scale factor attached to the resolution, and the aspect ratio all the way to the right like this one:

I also considered your last one with three evenly divided spaces but it feels off because no other place in the game is this dialog displayed in such a way.

I think headers for the columns aren't really necessary and would just require more work trying to invent a new look for this dialog.

[Osmodium]

Hi @zenseii I have introduced the 2 column layout again, which looks like this: The left and right padding might need to be more that 6 pixels, what do you think?

[Osmodium]

@ihhub Do you have further to this issue? :)

[ihhub]

@ihhub Do you have further to this issue? :)

Hi @Osmodium , I will review this pull request again tomorrow. It is on my TODO list. I am also adding @Branikolog to gather his opinion.

[Branikolog]

Hi @ihhub and @Osmodium Sorry, but I'm not really satisfied how this window looks now. It's not so bad though and I can accept it, but I wish it looks more elegant... The aspect ratio feature is good, but I personally cannot propose any good looking integration of this feature into the current window. Maybe we need more global rework of the whole window now? Also, I'm concerning about the variety of available aspect ratio values.

Could we approximate the first number, which is before the colon ( : ) in such way, so the second number would take more common values, like 3,4,9 or 10? I think it's more demonstrative to have like [15.9 : 9] or [17.7 : 10] rather than [62 : 35].