fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Update German translation

Open Laserlicht opened this issue 2 years ago • 10 comments

Laserlicht avatar Nov 06 '22 21:11 Laserlicht

Hi @zenseii. Thank you very much. Should be better now. 😊

Laserlicht avatar Nov 09 '22 22:11 Laserlicht

@a1exsh & @zenseii Thank you very much. :) I have implemented your changes. maybe you can take a second look.

Laserlicht avatar Nov 11 '22 01:11 Laserlicht

@Laserlicht please check all places where "Kampagne" is used and change it to "Feldzug", not only limited to the lines you have changed in this PR. Also, let's carefully review the "der/die/das" in each case where it's introduced by the PR and see if we can avoid the mismatch by phrasing it differently.

a1exsh avatar Nov 12 '22 18:11 a1exsh

@Laserlicht please check all places where "Kampagne" is used and change it to "Feldzug", not only limited to the lines you have changed in this PR.

Done 😉

Laserlicht avatar Nov 12 '22 18:11 Laserlicht

@Laserlicht please check all places where "Kampagne" is used and change it to "Feldzug", not only limited to the lines you have changed in this PR.

Done wink

Very good. :+1:

And what about der/die/das? Do you need help to rearrange the affected phrases?

a1exsh avatar Nov 13 '22 08:11 a1exsh

@Laserlicht please check all places where "Kampagne" is used and change it to "Feldzug", not only limited to the lines you have changed in this PR.

Done wink

Very good. 👍

And what about der/die/das? Do you need help to rearrange the affected phrases?

If you want, with pleasure. :)

Laserlicht avatar Nov 13 '22 11:11 Laserlicht

I think we should merge the PR.

It's been open for so long and I have to do a lot of things to bring it up to date.

Other changes (e.g. grammar) should then be made separately, I think.

Laserlicht avatar Dec 17 '22 13:12 Laserlicht

Yes, I think the dot would be more important. The fields are also partly somewhat smaller (or the font larger) than in the original German assets, so that I had to abbreviate them partly.

The Eszet (ß) I have replaced as already seen by ss. This is also the case in the original. But of course ß would be nicer.

Laserlicht avatar Dec 17 '22 16:12 Laserlicht

@zenseii please have a look 😊

Laserlicht avatar Dec 22 '22 20:12 Laserlicht

@zenseii done 😊

Laserlicht avatar Dec 22 '22 22:12 Laserlicht

@Laserlicht , huge thanks for improving this translation!

ihhub avatar Dec 30 '22 14:12 ihhub