fheroes2
fheroes2 copied to clipboard
ihhub
Build script updates for Windows/MSYS2/MINGW and translations
Current issues:
Probably many, but the generated languages work in-game, so that's a plus.
The Ninja generator doesn't build translations on every run.
~~Ninja generator converts the symbols in sed to some weird characters. Don't know what to do about that yet (I think the was in ENCODING override in CMake, though, will need to look). Using escape sequences, while ugly, seems to be the only workaround so far. The MSVC generator also has an issue with the sed command, which I can reproduce in command prompt. Will probably need different character escapes. Working on it now.~~ Using script files works on every platform and generator.
~~The Romanian translation was added while I was working on this. It was mentioned in the Makefile, but the file itself was missing. This script currently doesn't support it. It will probably generate garbage or fail to build.~~ Romanian works fine now.
Hi @hgdagon! Thank you for looking into this. I see that you are making changes to the makefile in files/lang. Are they compatible with this PR https://github.com/ihhub/fheroes2/pull/5498 by @undef21 ?
@zenseii Oh, neat! No, it's not compatible, but I think this will be ongoing for some time. The checks will probably find many more issues. If/when that PR is approved, I can then make changes on my side.
I am closing this pull request as @hgdagon has not been responding since July and most of changes in this pull request are incompatible anymore due to similar changes being merged in the past.
@hgdagon if you still would like to incorporate some changes of your into this repository please open a new pull request while focusing on separate issues in the code rather than fixing many at once.
@ihhub I don't seem to have any more free time recently. I have since forgotten what I even changed here. Please go ahead and close this. My apologies for wasting everybody's time.