fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Show the 4 primary skill icons +1 for xanadu visit

Open zenseii opened this issue 2 years ago • 11 comments

Preliminary checks

Describe the problem requiring a solution

Currently when visiting the xanadu and you are granted the primary skill bonus you only get a text which is not in line with the style of the rest of the game because there's no visual queue showing what you got.

image

Describe the possible solution

Maybe a stacked primary skill icon sort of like mass haste and a +1 next to it?

Additional info

Visit the Xanadu and have a hero at least level 10 minus level of diplomacy.

zenseii avatar Apr 10 '22 19:04 zenseii

@zenseii , like this? image

ihhub avatar Apr 11 '22 07:04 ihhub

@zenseii , like this? image

This looks good too. I was actually thinking about the smaller icons you see when visiting the arena. I'll show a quick edit in a sec.

zenseii avatar Apr 11 '22 08:04 zenseii

This would keep the dialog smaller and just add a +1 next to the stacked icon. Or you could just show all the small icons. primskills

The yellow-bordered icons might look better.

zenseii avatar Apr 11 '22 08:04 zenseii

The problem is that other dialogs have icons which are shown in my screenshot.

ihhub avatar Apr 11 '22 08:04 ihhub

The problem is that other dialogs have icons which are shown in my screenshot.

Right, then we can separate the 4 icons and have the informative dialog work for each of them, maybe in the same 2x2 alignment that you used or just 4x1. I see that these smaller icons have the right-click informative dialogs for when visiting the arena so it wouldn't feel out of place.

The only benefit to using the smaller icons would be to keep the dialog from getting too big. I also feel that those bigger icons are usually shown when there are at most 2 of them in the same dialog. 4 seems like a lot. On the other hand, the bigger icons do maybe fit better with the idea of this being a very good bonus.

Using the smaller icons would probably look very similar to the arena, which might be a reason to avoid having them like that to avoid confusion maybe.

zenseii avatar Apr 11 '22 08:04 zenseii

Hello @zenseii and @ihhub,

I made a proposal here https://github.com/ihhub/fheroes2/discussions/4877 for a similar display as for the Arena window.

In my opinion, the four large icons would be a bit overwhelming in this case.

LeHerosInconnu avatar Apr 11 '22 13:04 LeHerosInconnu

Hi, everyone.

I realized that the small icons are only present with the Price of Loyalty expansion so I think it would be best to go for the larger icons. I've still think I need to see this dialog with the 640x480 game screen to know whether they are too large or not.

zenseii avatar Sep 23 '22 21:09 zenseii

We can use icons from Kingdom Summary window.

ihhub avatar Sep 24 '22 10:09 ihhub

We can use icons from Kingdom Summary window.

Yep, they are perfect. This also makes them different enough from the arena icons to avoid the confusing we were talking about.

zenseii avatar Sep 24 '22 10:09 zenseii

image

ihhub avatar Sep 24 '22 10:09 ihhub

Yes that looks good. I realized they are the same as for the arena but having all 4 icons makes the dialogs distinguishable. An alternative is to have them in 2x2.

Also a +1 on the icon itself like you did earlier, and maybe a text beneath the icons with the name of the skill like in the arena.

zenseii avatar Sep 24 '22 10:09 zenseii

This issue is still valid. I vote for the icons from the last image and in a 2x2 order, instead of 1x4 like in the image provided. I also suggest writing "+1" below the 4 of them or somewhere to indicate the improvement.

zenseii avatar Aug 20 '23 17:08 zenseii